Skip to content

Conversation

@lonegunmanb
Copy link
Member

@lonegunmanb lonegunmanb commented Sep 2, 2025

Summary

This PR adds support for the missing gpu_driver parameter in node pools, resolving the breaking change issue where GPU node pools were being recreated during module upgrades.

Solves #692

Changes Made

  • ✅ Added gpu_driver parameter to node_pools variable schema in variables.tf
  • ✅ Implemented gpu_driver configuration in both node pool resources in extra_node_pool.tf
  • ✅ Updated documentation with valid values (Install, None)
  • ✅ Maintains backward compatibility - parameter is optional

Problem Solved

  • Users can now upgrade from version 9.4.0 to 10.2.0+ without forced replacement of GPU node pools
  • The gpu_driver parameter was missing from the module, causing configuration drift
  • GPU nodes can now properly configure driver installation (Install or None)

Testing

  • Code follows existing patterns and conventions
  • Parameter is properly passed through to both node pool resource variants
  • Documentation updated automatically via terraform-docs

Impact


🤖 This pull request was composed by GitHub Copilot agent.

- Add gpu_driver parameter to node_pools variable schema
- Implement gpu_driver configuration in both node pool resources
- Update documentation with valid values (Install, None)
- Resolves issue where gpu_driver parameter was missing causing
  forced replacement of GPU node pools during upgrades

Fixes #692
@lonegunmanb lonegunmanb changed the title 🤖 feat: add gpu_driver parameter support for node pools 🤖 feat: add gpu_driver parameter support for node pools Sep 2, 2025
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM

@lonegunmanb lonegunmanb merged commit 1656221 into main Sep 2, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Azure Module Kanban Sep 2, 2025
@lonegunmanb lonegunmanb deleted the feat/692 branch September 2, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants