Use single FRT #1470
Use single FRT #1470
Conversation
…action is required
# Conflicts: # IdentityCore/src/MSIDConstants.h # IdentityCore/src/requests/MSIDInteractiveAuthorizationCodeRequest.m
…re flight sent by broker
# Conflicts: # changelog.txt
… states: - On - Off - Ignore, keep as is
| @@ -60,6 +62,11 @@ | |||
| NSString *const MSID_THROTTLING_METADATA_KEYCHAIN = @"com.microsoft.identity.throttling.metadata"; | |||
| NSString *const MSID_THROTTLING_METADATA_KEYCHAIN_VERSION = @"Ver1"; | |||
|
|
|||
| NSString *const MSID_USE_SINGLE_FRT_KEYCHAIN = @"useSingleFRT"; | |||
There was a problem hiding this comment.
nit: can we also update "buttler" app to read this new keychain?
There was a problem hiding this comment.
Yes, I will update it
| @@ -241,7 +275,21 @@ - (MSIDRefreshToken *)getRefreshableTokenWithAccount:(MSIDAccountIdentifier *)ac | |||
|
|
|||
| if (refreshToken) | |||
| { | |||
| MSID_LOG_WITH_CTX(MSIDLogLevelVerbose, context, @"(Default accessor) Found %@refresh token by home account id", credentialType == MSIDPrimaryRefreshTokenType ? @"primary " : @""); | |||
| NSString *credentialTypeString = nil; | |||
| if (credentialType == MSIDPrimaryRefreshTokenType) | |||
There was a problem hiding this comment.
can we read this directly from refreshToken? i.e:
[refreshToken credentialTypeString]
We will be able to reuse it in another places too.
There was a problem hiding this comment.
Updated with existing method [MSIDCredentialTypeHelpers credentialTypeAsString:credentialType]
There was a problem hiding this comment.
Hi @juan-arias is there a rollout plan and can we make sure the single FRT is one when running MSAL and Broker automations?
|
Please double check by having this feature on and run against the automation pipeline |
# Conflicts: # changelog.txt
… use method from MSIDAccountCredentialCache instead. Update usage and tests.
# Conflicts: # changelog.txt
|
MSAL C++ errors are happening because of the new enum |
Proposed changes
Update the use of family refresh tokens, and instead use a single family refresh token.
Type of change
Risk
Additional information