-
Notifications
You must be signed in to change notification settings - Fork 36
Use single FRT #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Use single FRT #1470
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b7ac9d4
Use a single FRT if configured and enabled
juan-arias 7250799
Remove not used file
juan-arias 63a1fa9
Allow MSAL apps to disable single FRT
juan-arias 034c23a
Merge branch 'dev' into jarias/use-single-frt
juan-arias c22fe16
Send refresh token to web view to prevent password prompts when inter…
juan-arias 3aa7008
Add extra logs, don't send extra custom headers when using broker
juan-arias 2e732d1
Store flag to disable FRT in requestContext instead of msidConfigurat…
juan-arias 0e2175f
Merge branch 'dev' into jarias/use-single-frt
juan-arias 340f3d3
Return reason why FRT is enabled or not.
juan-arias 748fed2
Clean commented code
juan-arias 9adf79b
Merge branch 'dev' into jarias/use-single-frt
juan-arias 357ac47
Merge branch 'dev' into jarias/use-single-frt
juan-arias 3c5a825
Refactor SFRT code to now handle activation/deactivation from a featu…
juan-arias cee6ee5
Add server side telemetry
juan-arias 2f5fb2f
Merge branch 'dev' into jarias/use-single-frt
juan-arias 248c3b1
Update changelog
juan-arias 477991e
Fix build error
juan-arias 006c43d
Fix build error
juan-arias c443a0b
Merge branch 'dev' into jarias/use-single-frt
juan-arias d8c4614
Address PR comments
juan-arias 0fbe5d1
Merge branch 'dev' into jarias/use-single-frt
juan-arias 48800fb
Decide to enable/disable single frt based on string flight to allow 3…
juan-arias 742807e
Address PR comments
juan-arias 68ba038
Merge branch 'dev' into jarias/use-single-frt
juan-arias ca247b9
Address comments
juan-arias 244693c
Do not use context variable to allow client MSAL disable FRT feature;…
juan-arias 1d6a7b1
Merge branch 'dev' into jarias/use-single-frt
juan-arias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,8 @@ | |
NSString *const MSID_APP_NAME_KEY = @"x-app-name"; | ||
NSString *const MSID_APP_VER_KEY = @"x-app-ver"; | ||
NSString *const MSID_CCS_HINT_KEY = @"X-AnchorMailbox"; | ||
NSString *const MSID_WEBAUTH_IGNORE_SSO_KEY = @"x-ms-sso-Ignore-SSO"; | ||
NSString *const MSID_WEBAUTH_REFRESH_TOKEN_KEY = @"x-ms-sso-RefreshToken"; | ||
|
||
NSString *const MSID_DEFAULT_FAMILY_ID = @"1"; | ||
NSString *const MSID_ADAL_SDK_NAME = @"adal-objc"; | ||
|
@@ -60,6 +62,9 @@ | |
NSString *const MSID_THROTTLING_METADATA_KEYCHAIN = @"com.microsoft.identity.throttling.metadata"; | ||
NSString *const MSID_THROTTLING_METADATA_KEYCHAIN_VERSION = @"Ver1"; | ||
|
||
NSString *const MSID_USE_SINGLE_FRT_KEYCHAIN = @"useSingleFRT"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: can we also update "buttler" app to read this new keychain? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I will update it |
||
NSString *const MSID_USE_SINGLE_FRT_KEY = @"use_single_frt"; | ||
|
||
NSString *const MSID_SHARED_MODE_CURRENT_ACCOUNT_CHANGED_NOTIFICATION_KEY = @"SHARED_MODE_CURRENT_ACCOUNT_CHANGED"; | ||
|
||
NSString *const MSID_PREFERRED_AUTH_METHOD_KEY = @"pc"; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.