-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update msal-react to use react 19 #7467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
edf6e44 to
d3e11a1
Compare
|
@arjenbloemsma arjenbloemsma Nice! Waiting for this update! |
Thanks @smolaolga My pleasure |
|
To unblock my project, I've published a npm package of the msal-react fork. This allows us to keep moving forward and use react 19 in dev and test while the official package has not yet been released. Once the new version of official msal-react is released we can simply change back to that package, rebuild and move on. For those interested in following a similar approach; https://www.npmjs.com/package/@arjenbloemsma/msal-react |
lib/msal-react/package.json
Outdated
| "@types/node": "^20.5.1", | ||
| "@types/react": "^18.2.13", | ||
| "@types/react-dom": "^18.2.6", | ||
| "@types/react": "^19.0.01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be 19.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the sharp eye @jbouder. 🙏
It actually needs to be 19.0.2 (see https://www.npmjs.com/package/@types/react) to be in sync with the @types/react-dom package.
Just pushed the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to help. Honestly wasn't even trying to provide any feedback, but I saw it and my OCD kicked in :D
|
Would it be possible to put some priority in this issue? |
b577d75 to
9ae4c0e
Compare
|
See this pull request: |
React 19 stable has been released on December 5th (see announcement). This PR updates the react packages to version 19 and also sets the peerDependecies to reflect this.
This change will allow msal-react to be used in projects that use react 19 and enables existing projects that use react and msal-react to upgrade to react 19.
All test succeed:
See issue #7455