Skip to content

Conversation

@arjenbloemsma
Copy link

@arjenbloemsma arjenbloemsma commented Dec 14, 2024

React 19 stable has been released on December 5th (see announcement). This PR updates the react packages to version 19 and also sets the peerDependecies to reflect this.

This change will allow msal-react to be used in projects that use react 19 and enables existing projects that use react and msal-react to upgrade to react 19.

All test succeed:

image

See issue #7455

@github-actions github-actions bot added documentation Related to documentation. msal-browser Related to msal-browser package msal-react Related to @azure/msal-react labels Dec 14, 2024
@arjenbloemsma arjenbloemsma force-pushed the chore/update-to-react-19 branch from edf6e44 to d3e11a1 Compare December 14, 2024 15:09
@github-actions github-actions bot removed documentation Related to documentation. msal-browser Related to msal-browser package labels Dec 14, 2024
@smolaolga
Copy link

@arjenbloemsma arjenbloemsma Nice! Waiting for this update!

@arjenbloemsma
Copy link
Author

@arjenbloemsma arjenbloemsma Nice! Waiting for this update!

Thanks @smolaolga My pleasure

@arjenbloemsma
Copy link
Author

To unblock my project, I've published a npm package of the msal-react fork. This allows us to keep moving forward and use react 19 in dev and test while the official package has not yet been released. Once the new version of official msal-react is released we can simply change back to that package, rebuild and move on.

For those interested in following a similar approach; https://www.npmjs.com/package/@arjenbloemsma/msal-react

"@types/node": "^20.5.1",
"@types/react": "^18.2.13",
"@types/react-dom": "^18.2.6",
"@types/react": "^19.0.01",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be 19.0.1

Copy link
Author

@arjenbloemsma arjenbloemsma Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the sharp eye @jbouder. 🙏

It actually needs to be 19.0.2 (see https://www.npmjs.com/package/@types/react) to be in sync with the @types/react-dom package.

Just pushed the change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to help. Honestly wasn't even trying to provide any feedback, but I saw it and my OCD kicked in :D

@TomTom-Labs
Copy link

Would it be possible to put some priority in this issue?
We would like to switch to react 19, asap.
The reason is that there is a vulnerability reports coming in for older libraries and we would like to update to the newest available packages.

@Ben-CA
Copy link

Ben-CA commented Apr 28, 2025

See this pull request:
#7710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

msal-react Related to @azure/msal-react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants