Support typed injection in Angular #7651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shylasummers
requested review from
jo-arroyo,
tnorling and
peterzenz
as code owners
shylasummers
changed the title
|
Please merge my PR #7484 instead of taking my implementation and submitting a PR for my work under your own name. |
|
Hi @bradkovach, we made a separate PR because we needed to make a different change file and because we're not merging this PR into the dev branch. |
microsoft-github-policy-service
bot
added
the
Needs: Attention 👋
|
Closing in favor of #7745, which preserves commit history |
microsoft-github-policy-service
bot
removed
the
Needs: Attention 👋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported by @bradkovach and uses the solution suggested in #7484