Adjust InjectionToken<T> constants in msal-angular to support typed Angular 14+ inject()

[bradkovach]

This PR adjusts InjectionToken instantiation to use the proper template type parameter (instead of string), so that the new Angular 14+ inject(TOKEN) syntax can be used if desired.

import { MSAL_INSTANCE, MSAL_GUARD_CONFIG, MSAL_INTERCEPTOR_CONFIG, MSAL_BROADCAST_CONFIG
@Component({
   // ...
})
export class MyComponent {
   msalInstance = inject(MSAL_INSTANCE); // resolves to IPublicClientApplication
   msalGuardConfig = inject(MSAL_GUARD_CONFIG); // resolves to MsalGuardConfiguration
   msalInterceptorConfig = inject(MSAL_INTERCEPTOR_CONFIG); // resolves to MsalInterceptorConfiguration
   msalBroadcastConfig = inject(MSAL_BROADCAST_CONFIG); // resolves to MsalBroadcastConfiguration
}

[bradkovach]

@microsoft-github-policy-service agree

[bradkovach]

This is related to #7413, and fixes #6006

For anyone having issues with this, you can add some new constants to your own project to replace the existing broken ones.

export const TYPED_MSAL_INSTANCE =
  MSAL_INSTANCE as unknown as InjectionToken<IPublicClientApplication>;
export const TYPED_MSAL_GUARD_CONFIG =
  MSAL_GUARD_CONFIG as unknown as InjectionToken<MsalGuardConfiguration>;
export const TYPED_MSAL_INTERCEPTOR_CONFIG =
  MSAL_INTERCEPTOR_CONFIG as unknown as InjectionToken<MsalInterceptorConfiguration>;
export const TYPED_MSAL_BROADCAST_CONFIG =
  MSAL_BROADCAST_CONFIG as unknown as InjectionToken<MsalBroadcastConfiguration>;

[bradkovach]

bump; still an issue in latest versions

@jo-arroyo @peterzenz @tnorling let me know if anything else can be done to move this DX fix along.

[shylasummers]

Thank you! As this is a breaking change, it will be included in the next major release of MSAL Angular. See #7651

[bradkovach]

@shylasummers why are you closing my PR, re-implementing my work verbatim, and attributing this to yourself?

[shylasummers]

@bradkovach If you would like this PR specifically merged, you would need to change the changefile to be a major version type (since this is a breaking change) and change the branch to merge into msal-v5

[bradkovach]

This is done @shylasummers

The branches for dev and msal-v5 have diverged. Is dev regularly merged into v5?

If these need to be isolated from other commits in the graph, i can make a branch from v5 and cherry pick

[bradkovach]

@shylasummers are you able to perform the proper git steps to merge this, or should i make a new branch and another PR?

[bradkovach]

Closing in favor of #7653, which is using a different branch (based off of msal-v5 instead of dev)