Rename ConArg -> OtherConArg in VerilogRepr#39
Merged
Conversation
quark17
reviewed
Dec 21, 2025
| verilogTypeId' _ = integerToString $ valueOf i | ||
|
|
||
| instance TypeId' ConArg where | ||
| instance TypeId' OtherConArg where |
Collaborator
There was a problem hiding this comment.
Is it necessary to add instances for StarConArg and NumConArg too?
Contributor
Author
There was a problem hiding this comment.
Yeah, our internal version of the library has that, and other changes. I intend to update this in a separate pull request (there is some work to do now in pulling out some special cases for things in our code base.) This is just a minimal change to make it compile with the generics changes, for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See B-Lang-org/bsc#855