Skip to content

Rename ConArg -> OtherConArg in VerilogRepr #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quark17 merged 1 commit into from
Jan 10, 2026
Merged

Rename ConArg -> OtherConArg in VerilogRepr #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/VerilogRepr/VerilogRepr.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ instance TypeId' (NumArg i) where
bsType' _ = integerToString $ valueOf i
verilogTypeId' _ = integerToString $ valueOf i

instance TypeId' ConArg where
instance TypeId' OtherConArg where

@quark17 quark17 Dec 21, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to add instances for StarConArg and NumConArg too?

@krame505 krame505 Dec 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, our internal version of the library has that, and other changes. I intend to update this in a separate pull request (there is some work to do now in pulling out some special cases for things in our code base.) This is just a minimal change to make it compile with the generics changes, for now.

bsType' _ =
error "Demanded Bluespec type of a higher-kinded type argument"
verilogTypeId' _ =
Expand Down
Loading