Add more dependencies to root JSON file #6189
Conversation
EZoni
added
component: third party
EZoni
changed the title
| description="""Wrapper of WarpX""", | ||
| package_data=package_data, | ||
| install_requires=["numpy", "picmistandard==0.33.0", "periodictable"], | ||
| install_requires=["numpy", f"picmistandard=={picmi_version}", "periodictable"], |
There was a problem hiding this comment.
I think the file here should maybe just use requirements.txt instead of documenting the dependencies again...?
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
This looks great to me, thank you!
|
I think there is one more problem to fix, both here and in pyAMReX. For release updates we replace the commit hash with the release tag. However, I think this is buggy for dependencies that do not publish monthly releases regularly, e.g., pybind11 or even PICSAR. Replacing a commit hash from the latest weekly update with the latest available release tag may actually bring us backward in the commit history, if the latest available release tag is older than the latest commit. I think we should be doing something different. I don't see major drawbacks in always keeping the version and the commit separate from each other, using the release tag only for the version (e.g., |
EZoni
changed the title
EZoni
changed the title
|
In view of the upcoming monthly release, this may be worth reviewing. In particular, the outstanding questions in #6189 (comment). |
We generally try to publish our releases only on tags, because otherwise we make the live of downstream package maintainers (spack, conda, etc.) very hard. For pybind11, I always use published releases. Some tags might be from prior months in our dependencies, which is fine. |
dependencies.json
Outdated
| "commit_picsar": "0c329e66010267662a82219f7de7abbd231463f4" | ||
| } | ||
| "commit_picsar": "0c329e66010267662a82219f7de7abbd231463f4", | ||
| "commit_pybind11": "af796d0a99f0cbd9aebb10591257c41a56811cf6", |
There was a problem hiding this comment.
How did you end up with this sha exactly?
pybind11 tag v3.0.1 is commit f5fbe867d2d26e4a0a9177a51f6e568868ad3dc8
| if args.all or args.pybind11: | ||
| repo_dict["pybind11"] = {} | ||
| repo_dict["pybind11"]["commit"] = ( | ||
| "https://api.github.com/repos/pybind/pybind11/commits/master" | ||
| ) | ||
| repo_dict["pybind11"]["tags"] = ( | ||
| "https://api.github.com/repos/pybind/pybind11/tags" | ||
| ) |
There was a problem hiding this comment.
Note that we do not do a weekly tracking of pybind11. We manually update when we want a newer release.
Most importantly, when we release WarpX we do not depend on the pybind11 development branch (or any dependency as of their development branch).
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
The logic here is off for at least pybind11.
Note that we do on release track a tag, not development. We only track (some) dependencies development weekly between releases.
|
I pushed a fix similar to AMReX-Codes/pyamrex#517. |
2 participants
Add more dependencies to the JSON file in the root directory, to improve automation: