Skip to content

Conversation

@EZoni
Copy link
Member

@EZoni EZoni commented Nov 20, 2025

Overview

Coming soon...

To do

  • Particle component names
  • Particle user attributes?

@EZoni EZoni requested review from WeiqunZhang and atmyers November 20, 2025 22:06
@EZoni
Copy link
Member Author

EZoni commented Nov 20, 2025

Just with 23f28a3, the following tests failed:

  • test_2d_rigid_injection_lab
  • test_3d_collider_diagnostics

@EZoni EZoni added bug Something isn't working bug: affects latest release Bug also exists in latest release version labels Nov 20, 2025
@EZoni
Copy link
Member Author

EZoni commented Nov 20, 2025

Here's what I'm seeing for test_3d_collider_diagnostics with some prints inside DefaultInitializeRuntimeAttributes:

  • This branch:
ptile.NAR = 7
ptile.NAI = 0
ptile.NStructReal = 0
ptile.NStructInt = 0
particle_comps.size() = 0
particle_icomps.size() = 0
user_real_attribs.size() = 0
user_int_attribs.size() = 0
ptile.NumRealComps() = 8
ptile.NumIntComps() = 0
ptile.NumRuntimeRealComps() = 1
ptile.NumRuntimeIntComps() = 0
  • Main branch:
ptile.NAR = 7
ptile.NAI = 0
ptile.NStructReal = 0
ptile.NStructInt = 0
particle_comps.size() = 8
particle_icomps.size() = 0
user_real_attribs.size() = 0
user_int_attribs.size() = 0
ptile.NumRealComps() = 8
ptile.NumIntComps() = 0
ptile.NumRuntimeRealComps() = 1
ptile.NumRuntimeIntComps() = 0
particle_comps: x
particle_comps: y
particle_comps: z
particle_comps: w
particle_comps: ux
particle_comps: uy
particle_comps: uz
particle_comps: opticalDepthQSR

So what was previously passed as an argument, e.g., via pc.GetRealSoANames(), isn't equivalent to what is set here via ptile.GetStructOfArrays().GetRealNames(), as expected, but the previous implementation seems to be the one returning the correct names for the real components, while the new implementation seems to return an empty vector.

@WeiqunZhang
Copy link
Member

@EZoni Maybe you can do both. If SoA's GetRealNames return non-empty vector, use it, otherwise do it the old way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: affects latest release Bug also exists in latest release version bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants