client: run benchmarks on startup if new install or upgrade

[davidpanderson]

Previous: we ran benchmarks only after attaching to a project.

[Copilot]

Pull Request Overview

This PR introduces logic to run benchmarks on client startup during new installations or upgrades. The key changes include updating compiler flags, removing redundant version assignments when creating a new state file, and modifying benchmark eligibility checks.

• Updated Makefile.linux to disable the fstack-clash-protection flag.
• Removed legacy version assignments in cs_statefile.cpp.
• Modified the conditions to run CPU benchmarks in cs_benchmark.cpp and client_state.cpp.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
lib/Makefile.linux	Disabled fstack-clash-protection via commenting the flag out.
client/cs_statefile.cpp	Removed assignment of version values when creating a new state file.
client/cs_benchmark.cpp	Removed check for attached projects before running benchmarks.
client/client_state.cpp	Introduced a condition to trigger benchmarks based on host_info.p_fpops.

Comments suppressed due to low confidence (3)

client/cs_benchmark.cpp:328

• The removal of the check for no attached projects will allow benchmarks to run even when there are no projects attached. Confirm that this behavior is consistent with the intended design for new installations.

    if (tasks_suspended) return false;

client/client_state.cpp:784

• [nitpick] Consider adding a comment to clarify the rationale behind using host_info.p_fpops as an indicator for running CPU benchmarks to improve maintainability.

    if (host_info.p_fpops == 0) {

client/cs_statefile.cpp:109

• Removing the legacy version assignments in the new state file path may lead to inconsistencies in version tracking. Please confirm that this change won’t affect the detection logic for new installations or upgrades.

        return ERR_FOPEN;