Skip to content

client: run benchmarks on startup if new install or upgrade #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AenBleidd merged 1 commit into from
Jun 25, 2025
Merged

client: run benchmarks on startup if new install or upgrade #6404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions client/client_state.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,14 +422,16 @@ bool CLIENT_STATE::is_new_client() {
|| (core_client_version.minor != old_minor_version)
|| (core_client_version.release != old_release)
) {
msg_printf_notice(0, true, 0,
"The BOINC client version has changed from %d.%d.%d to %d.%d.%d.<br>To see what's new, view the <a href=%s>Client release notes</a>.",
old_major_version, old_minor_version, old_release,
core_client_version.major,
core_client_version.minor,
core_client_version.release,
"https://github.com/BOINC/boinc/wiki/Client-release-notes"
);
if (old_major_version) {
msg_printf_notice(0, true, 0,
"The BOINC client version has changed from %d.%d.%d to %d.%d.%d.<br>To see what's new, view the <a href=%s>Client release notes</a>.",
old_major_version, old_minor_version, old_release,
core_client_version.major,
core_client_version.minor,
core_client_version.release,
"https://github.com/BOINC/boinc/wiki/Client-release-notes"
);
}
new_client = true;
}
if (statefile_platform_name.size() && strcmp(get_primary_platform(), statefile_platform_name.c_str())) {
Expand Down Expand Up @@ -779,6 +781,9 @@ int CLIENT_STATE::init() {
net_status.need_to_contact_reference_site = true;
}
}
if (host_info.p_fpops == 0) {
run_cpu_benchmarks = true;
}

check_if_need_benchmarks();

Expand Down
5 changes: 0 additions & 5 deletions client/cs_benchmark.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,6 @@ void CLIENT_STATE::check_if_need_benchmarks() {
//
bool CLIENT_STATE::can_run_cpu_benchmarks() {
if (tasks_suspended) return false;

// if no projects attached yet, don't run
//
if (projects.size()==0) return false;

return true;
}

Expand Down
6 changes: 0 additions & 6 deletions client/cs_statefile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,6 @@ int CLIENT_STATE::parse_state_file() {
fname = STATE_FILE_PREV;
} else {
msg_printf(0, MSG_INFO, "Creating new client state file");

// avoid warning messages about version
//
old_major_version = BOINC_MAJOR_VERSION;
old_minor_version = BOINC_MINOR_VERSION;
old_release = BOINC_RELEASE;
return ERR_FOPEN;
}
return parse_state_file_aux(fname);
Expand Down
3 changes: 2 additions & 1 deletion lib/Makefile.linux
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ OPTS = -O2 -Wall -Wformat -Wformat=2 -Wconversion -Wimplicit-fallthrough \
-Werror=format-security \
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 \
-D_GLIBCXX_ASSERTIONS \
-fstack-clash-protection -fstack-protector-strong \
# -fstack-clash-protection \
-fstack-protector-strong \
-Wl,-z,nodlopen -Wl,-z,noexecstack \
-Wl,-z,relro -Wl,-z,now \
-Wl,--as-needed -Wl,--no-copy-dt-needed-entries
Expand Down