client (Win): don't recommend docker on Win 10 Home

[davidpanderson]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors the Docker installation notice logic to centralize URL assignment and suppress the recommendation on Windows 10 Home, where WSL is unsupported.

• Moved url declaration and initialization outside platform-specific branches.
• Added a check to set url = NULL for Windows 10 Home (identified by “Core” in os_version).
• Updated the notice condition to only trigger when url is non-null and Docker is missing.

Comments suppressed due to low confidence (2)

client/client_state.cpp:930

• The #ifndef ANDROID guard was removed, so this Docker notice logic now runs on Android builds as well. Consider reintroducing the Android exclusion to prevent incorrect recommendations on that platform.

    //

client/client_state.cpp:934

• There’s no unit test for the Windows 10 Home path—consider adding a test to verify that url is cleared and no Docker recommendation is shown for Home editions.

    if (strstr(host_info.os_name, "Windows 10") && strstr(host_info.os_version, "Core")) {

[Copilot]

[nitpick] Detecting Windows 10 Home via substring matching on os_version can be fragile (localization or format changes). It would be more robust to use a dedicated API or an explicit edition field if available.

[AenBleidd]

I'll keep this open since I want to test this first.
I found a little bit confusing information.
Before I read that WSL is not available on Win10 Home, but according to this page it is available.
I'll check this before the weekend and come with an answer

[AenBleidd]

This is not required. WSL2 is available on Windows 10 Home edition (tested on the release 22H2 build 19045.4291).