Skip to content

client (Win): don't recommend docker on Win 10 Home #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidpanderson wants to merge 1 commit into from
Closed

client (Win): don't recommend docker on Win 10 Home #6422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions client/client_state.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,15 +928,19 @@ int CLIENT_STATE::init() {

// if Docker not present, notify user
//
#ifndef ANDROID
const char* url = NULL;
#ifdef _WIN32
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Windows";
url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Windows";
if (strstr(host_info.os_name, "Windows 10") && strstr(host_info.os_version, "Core")) {
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Detecting Windows 10 Home via substring matching on os_version can be fragile (localization or format changes). It would be more robust to use a dedicated API or an explicit edition field if available.

Copilot uses AI. Check for mistakes.
// Core == Home. WSL not supported on Win 10 Home
url = NULL;
}
#elif defined(__APPLE__)
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Mac";
url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Mac";
#else
const char* url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Linux";
url = "https://github.com/BOINC/boinc/wiki/Installing-Docker-on-Linux";
#endif
if (!host_info.have_docker()) {
if (url && !host_info.have_docker()) {
msg_printf(NULL, MSG_INFO,
"Some projects require Docker."
);
Expand All @@ -951,7 +955,6 @@ int CLIENT_STATE::init() {
strcpy(n.category, "client");
notices.append(n);
}
#endif

initialized = true;
return 0;
Expand Down