[windows][mingw] fix build after lubcurl update#6445
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates Windows and MinGW build configurations to include new dependencies introduced by the libcurl update.
- Adds Iphlpapi.lib and Secur32.lib to the Visual Studio project’s linker settings.
- Appends the IP helper library flag to the sample Condor Makefile.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| win_build/sim.vcxproj | Include Iphlpapi.lib and Secur32.lib in AdditionalDependencies |
| samples/condor/Makefile | Add -lIphlpapi to CURL_EXTRA_LDFLAGS |
| </ClCompile> | ||
| <Link> | ||
| <AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
| <AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies> |
There was a problem hiding this comment.
[nitpick] The file extension casing for several libraries (e.g., Ws2_32.Lib, Crypt32.Lib, Wldap32.Lib) is inconsistent. Consider using lowercase .lib throughout (e.g., Ws2_32.lib) for consistency.
| <AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies> | |
| <AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.lib;Crypt32.lib;Wldap32.lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies> |
| </ClCompile> | ||
| <Link> | ||
| <AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
| <AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies> |
There was a problem hiding this comment.
[nitpick] The list of linker dependencies would be easier to read and maintain if it were alphabetized. Consider sorting these entries alphabetically.
| <AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies> | |
| <AdditionalDependencies>Crypt32.Lib;Iphlpapi.lib;libcrypto.lib;libssl.lib;oldnames.lib;Secur32.lib;wininet.lib;winmm.lib;Ws2_32.Lib;wsock32.lib;Wldap32.Lib;%(AdditionalDependencies)</AdditionalDependencies> |
samples/condor/Makefile
Outdated
| -L$(VCPKG_DIR)/lib | ||
|
|
||
| CURL_EXTRA_LDFLAGS ?= -lz -ldl | ||
| CURL_EXTRA_LDFLAGS ?= -lz -ldl -lIphlpapi |
There was a problem hiding this comment.
The -lIphlpapi flag is missing its counterpart -lsecur32, which was added in the Visual Studio project. Add -lsecur32 here to ensure builds don’t fail due to a missing security library.
| CURL_EXTRA_LDFLAGS ?= -lz -ldl -lIphlpapi | |
| CURL_EXTRA_LDFLAGS ?= -lz -ldl -lIphlpapi -lsecur32 |
samples/condor/Makefile
Outdated
| -L$(VCPKG_DIR)/lib | ||
|
|
||
| CURL_EXTRA_LDFLAGS ?= -lz -ldl | ||
| CURL_EXTRA_LDFLAGS ?= -lz -ldl -lIphlpapi |
There was a problem hiding this comment.
[nitpick] For consistency with common Unix linker conventions, consider using lowercase for the library flag (-liphlpapi instead of -lIphlpapi).
| CURL_EXTRA_LDFLAGS ?= -lz -ldl -lIphlpapi | |
| CURL_EXTRA_LDFLAGS ?= -lz -ldl -liphlpapi |
AenBleidd
force-pushed
the
vko_fix_win_build
branch
from
a9761e9 to
329b903
Compare
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
force-pushed
the
vko_fix_win_build
branch
from
329b903 to
dc89991
Compare
No description provided.