Skip to content

[windows][mingw] fix build after lubcurl update #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AenBleidd merged 1 commit into from
Jul 17, 2025
Merged

[windows][mingw] fix build after lubcurl update #6445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions samples/condor/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ ifdef BUILD_APPS_WITH_VCPKG
CURL_EXTRA_LDFLAGS ?= -lz -ldl
endif

ifdef BUILD_WITH_MINGW
CURL_EXTRA_LDFLAGS += -liphlpapi
endif

PROGS = boinc_gahp

all: $(PROGS)
Expand Down
2 changes: 1 addition & 1 deletion win_build/sim.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<PreprocessorDefinitions>_CONSOLE;SIM;%(PreprocessorDefinitions)</PreprocessorDefinitions>
</ClCompile>
<Link>
<AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;%(AdditionalDependencies)</AdditionalDependencies>
<AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies>
Copy link

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The file extension casing for several libraries (e.g., Ws2_32.Lib, Crypt32.Lib, Wldap32.Lib) is inconsistent. Consider using lowercase .lib throughout (e.g., Ws2_32.lib) for consistency.

Suggested change
<AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies>
<AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.lib;Crypt32.lib;Wldap32.lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies>

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The list of linker dependencies would be easier to read and maintain if it were alphabetized. Consider sorting these entries alphabetically.

Suggested change
<AdditionalDependencies>wsock32.lib;wininet.lib;winmm.lib;oldnames.lib;libcrypto.lib;libssl.lib;Ws2_32.Lib;Crypt32.Lib;Wldap32.Lib;Iphlpapi.lib;Secur32.lib;%(AdditionalDependencies)</AdditionalDependencies>
<AdditionalDependencies>Crypt32.Lib;Iphlpapi.lib;libcrypto.lib;libssl.lib;oldnames.lib;Secur32.lib;wininet.lib;winmm.lib;Ws2_32.Lib;wsock32.lib;Wldap32.Lib;%(AdditionalDependencies)</AdditionalDependencies>

Copilot uses AI. Check for mistakes.
<AdditionalDependencies Condition="'$(Configuration)'=='Debug'">zlibd.lib;libcurl-d.lib;%(AdditionalDependencies)</AdditionalDependencies>
<AdditionalDependencies Condition="'$(Configuration)'=='Release'">zlib.lib;libcurl.lib;%(AdditionalDependencies)</AdditionalDependencies>
<SubSystem>Console</SubSystem>
Expand Down
Loading