Conversation
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
force-pushed
the
vko_fix_mingw_build
branch
from
78623e3 to
5d02b86
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the PowerShell installation process in the MinGW CI workflow by consolidating multiple apt install commands and removing intermediate steps. The changes streamline the workflow while maintaining the same functionality for installing PowerShell dependencies and PowerShell itself.
- Consolidated package installation into fewer commands
- Removed intermediate variable assignment and separate update step
- Added non-interactive mode for apt installations
| sudo apt install -y powershell | ||
| sudo apt install -y wget apt-transport-https software-properties-common doxygen | ||
| wget -q https://packages.microsoft.com/config/ubuntu/$(lsb_release -r -s)/packages-microsoft-prod.deb | ||
| sudo DEBIAN_FRONTEND=noninteractive apt install -y ./packages-microsoft-prod.deb powershell |
There was a problem hiding this comment.
Installing the .deb package and PowerShell in the same command may cause issues if the package installation fails or if the apt cache needs to be updated after adding the new repository. Consider separating these into two commands: first install the .deb package with 'sudo dpkg -i', then run 'sudo apt update', and finally install PowerShell.
Suggested change
| sudo DEBIAN_FRONTEND=noninteractive apt install -y ./packages-microsoft-prod.deb powershell | |
| sudo dpkg -i packages-microsoft-prod.deb | |
| sudo apt update | |
| sudo apt install -y powershell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.