Skip to content

[ci] Fix mingw build #6453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AenBleidd merged 1 commit into from
Jul 21, 2025
Merged

[ci] Fix mingw build #6453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions .github/workflows/mingw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,9 @@ jobs:
- name: Install Powershell for vcpkg
if: success() && matrix.type == 'apps-mingw-vcpkg'
run: |
POWERSHELL_DEPS="wget apt-transport-https software-properties-common"
# Install pre-requisite packages of PowerShell
sudo apt install -y $POWERSHELL_DEPS doxygen
# Download the Microsoft repository GPG keys
VERSION=$(lsb_release -r -s)
wget -q https://packages.microsoft.com/config/ubuntu/$VERSION/packages-microsoft-prod.deb
# Register the Microsoft repository GPG keys
sudo dpkg -i packages-microsoft-prod.deb
# Update the list of packages after we added packages.microsoft.com
sudo apt update
# Install PowerShell
sudo apt install -y powershell
sudo apt install -y wget apt-transport-https software-properties-common doxygen
wget -q https://packages.microsoft.com/config/ubuntu/$(lsb_release -r -s)/packages-microsoft-prod.deb
sudo DEBIAN_FRONTEND=noninteractive apt install -y ./packages-microsoft-prod.deb powershell
Copy link

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing the .deb package and PowerShell in the same command may cause issues if the package installation fails or if the apt cache needs to be updated after adding the new repository. Consider separating these into two commands: first install the .deb package with 'sudo dpkg -i', then run 'sudo apt update', and finally install PowerShell.

Suggested change
sudo DEBIAN_FRONTEND=noninteractive apt install -y ./packages-microsoft-prod.deb powershell
sudo dpkg -i packages-microsoft-prod.deb
sudo apt update
sudo apt install -y powershell

Copilot uses AI. Check for mistakes.

- name: Automake vcpkg and cmake
if: success() && (contains(matrix.type, 'vcpkg') || contains(matrix.type, 'cmake'))
Expand Down
Loading