Skip to content

test: Fix cucumber variant assertions to include inherited properties #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoulton merged 1 commit into from
Nov 6, 2025
Merged

test: Fix cucumber variant assertions to include inherited properties #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tests/Cucumber/ParserResultDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,14 @@ private function recursiveDump(mixed $value): mixed
// we know that the FeatureNode and the objects it contains do not contain any recursive references.
$values = [];
$reflection = new ReflectionClass($value);
foreach ($reflection->getProperties() as $property) {
$values[$property->getName()] = match ($property->isInitialized($value)) {
true => $this->recursiveDump($property->getValue($value)),
false => '**NOT INITIALIZED**',
};
}
do {
foreach ($reflection->getProperties() as $property) {
$values[$property->getName()] = match ($property->isInitialized($value)) {
true => $this->recursiveDump($property->getValue($value)),
false => '**NOT INITIALIZED**',
};
}
} while ($reflection = $reflection->getParentClass());

return [$value::class => $values];
}
Expand Down
7 changes: 7 additions & 0 deletions tests/Cucumber/expected_variants/gherkin-32/padded_example.feature.expected.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ Behat\Gherkin\Node\FeatureNode:
Behat\Gherkin\Node\ExampleTableNode:
keyword: Examples
tags: []
maxLineLength:
- 9
table:
17:
- color
18:
- "\_ \tred\_ \t"
Copy link
Contributor Author

@acoulton acoulton Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm already aware of the padding variation - there's a skipped cucumber example for it but we didn't have an issue so have opened #395

examples: '**NOT INITIALIZED**'
title: test
tags: []
Expand Down
7 changes: 7 additions & 0 deletions tests/Cucumber/expected_variants/legacy/padded_example.feature.expected.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ Behat\Gherkin\Node\FeatureNode:
Behat\Gherkin\Node\ExampleTableNode:
keyword: Examples
tags: []
maxLineLength:
- 7
table:
17:
- color
18:
- "\_ \tred\_"
examples: '**NOT INITIALIZED**'
title: test
tags: []
Expand Down