Skip to content

Conversation

ozheng2
Copy link

@ozheng2 ozheng2 commented Jun 10, 2025

I cleaned up science.proto and drive.proto. I compared the respective .ino files, the .pb.h files, and other files for references to the variables in the .proto files.

Science.proto:

  • Removed version variables from ScienceCommand and ScienceData since I found no references to them

Drive.proto:

  • Removed version variable from DriveCommand since no references were found
  • Removed rpm variables from DriveData since no references were found
  • Added has_version variable to DriveData since drive.ino uses it

@ozheng2 ozheng2 requested review from Kenou2005 and ruari-r June 10, 2025 01:05
Copy link
Contributor

@Kenou2005 Kenou2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good, but we do want to keep the back_left, middle_left...etc fields for the motor speed This is in preparation for future incorpration.

@ozheng2
Copy link
Author

ozheng2 commented Jun 24, 2025

I added the motor rpm fields back to drive.proto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants