[patch] use binary encoding function that does not overflow for qr #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the qr codes get too big (in total file size), then the current function will blow up. This one works better, tested manually by updating the dist/build.js, and updating example.html to point to that instead of the production cdn hosted websdk
bredmond5
requested review from
chrisyeagy-branch,
jmalizia-branch and
mack-branch
mack-branch
approved these changes
Nov 4, 2024
mack-branch
left a comment
mack-branch
left a comment
There was a problem hiding this comment.
nice catch, glad we could fix this. we probably should let it sit for a bit before deploying linkifier just to be safe.
chrisyeagy-branch
approved these changes
Nov 4, 2024
Contributor
chrisyeagy-branch
left a comment
chrisyeagy-branch
left a comment
There was a problem hiding this comment.
im not sure why this fixes it, but i trust that you do.
15 tasks
bredmond5
added a commit
that referenced
this pull request
Nov 5, 2024
# Pull Request Template ## Description previous pr #1075 I didnt understand that i was supposed to do this before, updated now Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [ ] Unit test - [ ] Integration test ## JS Budget Check Please mention the size in kb before abd after this PR | Files | Before | After | | ----------- | ----------- | ----------- | | dist/build.js. | | | | dist/build.min.js| | | ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules - [ ] I have checked my code and corrected any misspellings ## Mentions: List the person or team responsible for reviewing proposed changes. cc @BranchMetrics/saas-sdk-devs for visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
If the qr codes get too big (in total file size), then the current function will blow up. This one works better, tested manually by updating the dist/build.js, and updating example.html to point to that instead of the production cdn hosted websdk
I couldnt get this new one to overflow
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
JS Budget Check
Please mention the size in kb before abd after this PR
Checklist:
Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.