Conversation
andz-bb
changed the title
185545c to
84d2d6b
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 18 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 19 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
ea29f10 to
514d238
Compare
There was a problem hiding this comment.
All reported issues were addressed across 25 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai rerun |
@andz-bb I have started the AI code review. It will take a few minutes to complete. |
822d645 to
8b5b8bf
Compare
|
@cubic-dev-ai rerun |
@andz-bb I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai rerun |
@andz-bb I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai rerun |
@andz-bb I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 28 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Re-trigger cubic
|
@cubic-dev-ai rerun |
@andz-bb I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
2 issues found across 28 files
Confidence score: 3/5
- In
packages/server/src/sdk/workspace/projects/backups/exports.ts, legacy datasources assigned only via an external table’sprojectIdsmay be omitted from exports and their dependencies, causing incomplete packages; preserve coverage for this assignment path and verify the export includes the datasource content and dependencies. - In
packages/server/src/api/routes/tests/resource.spec.ts, replacing the duplication test removes coverage for datasource duplication without its project, which could allow external-table project assignments to regress unnoticed; retain a case covering duplication without the project.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/server/src/sdk/workspace/projects/backups/exports.ts">
<violation number="1" location="packages/server/src/sdk/workspace/projects/backups/exports.ts:96">
P2: For legacy datasources assigned only through an external-table entity's `projectIds`, this export no longer treats the datasource as a direct member, so its content is silently omitted from the package and dependency index. The removed `getProjectAssignedEntities` path previously kept them. Confirm whether pre-migration entity-only assignments are still expected to export, and preserve their inclusion.</violation>
</file>
<file name="packages/server/src/api/routes/tests/resource.spec.ts">
<violation number="1" location="packages/server/src/api/routes/tests/resource.spec.ts:1124">
P2: This change removes the test "removes external table project assignments when duplicating a datasource without its project" and replaces it with a version that duplicates the datasource together with its project. As a result, the entity-level stripping path (external table `entities[*].projectIds` removed when a project-member datasource is duplicated on its own, without the project) is no longer covered. Only the with-project case is now pinned; datasource-level stripping without the project is covered by a different test but it has no external-table entities. Keep a separate case that duplicates the datasource without the project and asserts the external-table `projectIds` are stripped.</violation>
</file>
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 35 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
86195ef to
7ea754f
Compare
b159e03 to
a187ec1
Compare
This branch has not been deployed
2 participants
Description
adds the dependency and package foundation for projects.
covers owner exclusions, malformed packages, credential removal, remapping and import cleanup with API tests.
part 1 of the six-part projects stack. review against master. next: #19245.
Addresses
App Export
Screenshots
Launchcontrol
improves project export and import reliability, including portable views and credential removal