Conversation
|
@dmystical-coder is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
I touched the next configuration file so I could properly load GitHub avatar images using remotePatterns. |
melanke
left a comment
There was a problem hiding this comment.
Thank you for your personal page and for the perfect PR description :)
Here's my CR:
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
| const frontendSkills = ["React", "TypeScript", "NextJS", "TailwindCSS"]; | ||
|
|
||
| return ( | ||
| <div className="min-h-screen bg-white text-black font-mono pt-4"> |
There was a problem hiding this comment.
Your page looks good in light mode, but you might not have noticed the theme switcher at the bottom right corner. It would be great if your content adapted to the dark theme as well.
There was a problem hiding this comment.
Now it only works in dark mode.
Edit: It seems to be a bigger problem, the dark variant is being ignored in the whole project. Let me investigate this.
Edit2: The dark/light theme problem is fixed in origin/main branch, can you rebase your branch? Thanks
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
melanke
left a comment
There was a problem hiding this comment.
Thanks for the update, here are a few more comments:
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/next-env.d.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference types="next/navigation-types/compat/navigation" /> | |||
There was a problem hiding this comment.
Can you please revert the change to next-env.d.ts?
It seems unrelated to the remotePatterns config in next.config.ts or any other change you made in your PR, and might have been added by mistake or by your local setup. This file is usually managed automatically by Next.js and shouldn’t be edited manually unless necessary.
There was a problem hiding this comment.
Hi @melanke
I have tried to revert this change, but on committing the change, it reappears. Next.js is automatically regenerating the file during the build process.
Kindly advise.
There was a problem hiding this comment.
It's funny, it happens the opposite when I open your branch here on my machine. It erases this line.
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/icons.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x119d9A1ef0D16361284a9661727b363B04B5B0c8/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/next-env.d.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference types="next/navigation-types/compat/navigation" /> | |||
There was a problem hiding this comment.
It's funny, it happens the opposite when I open your branch here on my machine. It erases this line.
| const frontendSkills = ["React", "TypeScript", "NextJS", "TailwindCSS"]; | ||
|
|
||
| return ( | ||
| <div className="min-h-screen bg-white text-black font-mono pt-4"> |
There was a problem hiding this comment.
Now it only works in dark mode.
Edit: It seems to be a bigger problem, the dark variant is being ignored in the whole project. Let me investigate this.
Edit2: The dark/light theme problem is fixed in origin/main branch, can you rebase your branch? Thanks
Remove 'use client' directive from profile page to enable static rendering at build time. This improves performance by pre-rendering the page during compilation and reduces client-side JavaScript.
Replace repetitive social link elements with a mapping structure for better maintainability and reduced code duplication.
Remove manual changes to next-env.d.ts as it is an auto-generated file that should not be modified manually.
Move blockchainSkills, frontendSkills, socialLinks, and myAddress constants outside the component to prevent recreation on each render and improve performance.
Replace dynamic year calculation with static year 2025 in the footer message to accurately reflect the batch year.
Remove 'use client' directive from icon components since they are pure SVG elements that can be pre-rendered during build time, improving performance by reducing client-side JavaScript.
Remove hover:shadow-md class from footer message since it wasn't providing any visible effect and was adding unnecessary CSS to the bundle.
8e2c450 to
a3b5c81
Compare
|
@dmystical-coder, what a cool page! Really like the design, thank you so much for your effort! Let's merge :) Thanks @melanke for the review! |

Description
This PR adds my builder profile page to the batch site. I've created a new profile page with a little bio, avatar, address, skills and links to my socials.
Additional Information
Related Issues
This PR adds a new builder profile page to the platform as part of the Batch 16 contributions. Issue #8
Your ENS/address:
0x119d9A1ef0D16361284a9661727b363B04B5B0c8