Skip to content

Add BuilderProfile#16

Merged
phipsae merged 13 commits intoBuidlGuidl:mainfrom
dmystical-coder:b-PersonalPage
May 12, 2025
Merged

Add BuilderProfile#16
phipsae merged 13 commits intoBuidlGuidl:mainfrom
dmystical-coder:b-PersonalPage

Conversation

@dmystical-coder
Copy link
Contributor

Description

This PR adds my builder profile page to the batch site. I've created a new profile page with a little bio, avatar, address, skills and links to my socials.

  • Custom builder profile page with responsive design
  • Skills section highlighting blockchain and frontend technologies
  • Profile information with GitHub avatar and social links

image
image

Additional Information

Related Issues

This PR adds a new builder profile page to the platform as part of the Batch 16 contributions. Issue #8

Your ENS/address:
0x119d9A1ef0D16361284a9661727b363B04B5B0c8

@vercel
Copy link

vercel bot commented May 8, 2025

@dmystical-coder is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@dmystical-coder
Copy link
Contributor Author

I touched the next configuration file so I could properly load GitHub avatar images using remotePatterns.

Copy link
Collaborator

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your personal page and for the perfect PR description :)

Here's my CR:

const frontendSkills = ["React", "TypeScript", "NextJS", "TailwindCSS"];

return (
<div className="min-h-screen bg-white text-black font-mono pt-4">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your page looks good in light mode, but you might not have noticed the theme switcher at the bottom right corner. It would be great if your content adapted to the dark theme as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

@melanke melanke May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it only works in dark mode.

Edit: It seems to be a bigger problem, the dark variant is being ignored in the whole project. Let me investigate this.

Edit2: The dark/light theme problem is fixed in origin/main branch, can you rebase your branch? Thanks

Copy link
Collaborator

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, here are a few more comments:

@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the change to next-env.d.ts?
It seems unrelated to the remotePatterns config in next.config.ts or any other change you made in your PR, and might have been added by mistake or by your local setup. This file is usually managed automatically by Next.js and shouldn’t be edited manually unless necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @melanke
I have tried to revert this change, but on committing the change, it reappears. Next.js is automatically regenerating the file during the build process.
Kindly advise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny, it happens the opposite when I open your branch here on my machine. It erases this line.

@vercel
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch16.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 5:22pm

@@ -1,5 +1,6 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's funny, it happens the opposite when I open your branch here on my machine. It erases this line.

const frontendSkills = ["React", "TypeScript", "NextJS", "TailwindCSS"];

return (
<div className="min-h-screen bg-white text-black font-mono pt-4">
Copy link
Collaborator

@melanke melanke May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it only works in dark mode.

Edit: It seems to be a bigger problem, the dark variant is being ignored in the whole project. Let me investigate this.

Edit2: The dark/light theme problem is fixed in origin/main branch, can you rebase your branch? Thanks

Remove 'use client' directive from profile page to enable static rendering at build time. This improves performance by pre-rendering the page during compilation and reduces client-side JavaScript.
Replace repetitive social link elements with a mapping structure for better maintainability and reduced code duplication.
Remove manual changes to next-env.d.ts as it is an auto-generated file that should not be modified manually.
Move blockchainSkills, frontendSkills, socialLinks, and myAddress constants outside the component to prevent recreation on each render and improve performance.
Replace dynamic year calculation with static year 2025 in the footer message to accurately reflect the batch year.
Remove 'use client' directive from icon components since they are pure SVG elements that can be pre-rendered during build time, improving performance by reducing client-side JavaScript.
Remove hover:shadow-md class from footer message since it wasn't providing any visible effect and was adding unnecessary CSS to the bundle.
@melanke melanke requested a review from phipsae May 12, 2025 17:28
@phipsae
Copy link
Contributor

phipsae commented May 12, 2025

@dmystical-coder, what a cool page! Really like the design, thank you so much for your effort! Let's merge :)

Thanks @melanke for the review!

@phipsae phipsae merged commit f057cf5 into BuidlGuidl:main May 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants