Add unit tests for ColdfrontFetchProcessor#300
Open
marcoagonzales007 wants to merge 2 commits into
Open
Conversation
QuanMPhm
requested changes
Jun 4, 2026
Comment on lines
+274
to
+277
| @mock.patch( | ||
| "process_report.processors.coldfront_fetch_processor.ColdfrontFetchProcessor._fetch_coldfront_allocation_api", | ||
| ) | ||
| def test_get_allocation_data_missing_key(self, mock_get_allocation_data): |
Contributor
There was a problem hiding this comment.
Looking at this test, it does not seem like you need any mocking at all. The test itself can be shortened.
def test_get_allocation_data_missing_key(self):
"""Malformed allocation entries with missing keys are skipped."""
test_allocation_data = [
{
"resource": {"name": "stack"},
"project": {"pi": "PI1"},
"attributes": {},
}, # missing Allocated Project ID
]
proc = test_utils.new_coldfront_fetch_processor()
result = proc._get_allocation_data(test_allocation_data)
assert result == {}…_data_missing_key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #185
Adds additional unit tests for ColdfrontFetchProcessor bringing coverage from 76% to 82%.
Tests added:
test_get_coldfront_api_data_with_filepath— verifies that when a local filepath is provided data is read from the file insteadtest_get_allocation_data_missing_key— verifies that allocation entries with missing keys are skipped