Skip to content

Add unit tests for ColdfrontFetchProcessor #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcoagonzales007 wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −1
Open

Add unit tests for ColdfrontFetchProcessor #300

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b738c3
Add unit tests for ColdfrontFetchProcessor
marcoagonzales007 Jun 1, 2026
823de93
Address PR feedback: remove unnecessary mock from test_get_allocation…
marcoagonzales007 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion process_report/tests/unit/processors/test_coldfront_fetch_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from unittest import TestCase, mock
import pandas
import pytest

import json
from process_report.tests import util as test_utils


Expand Down Expand Up @@ -259,3 +259,31 @@ def test_missing_project_cluster_tuples(self, mock_get_allocation_data):
assert str(cm.value) == (
f"Projects {expected_missing} not found in Coldfront and are billable! Please check the project names"
)

def test_get_coldfront_api_data_with_filepath(self):
mock_api_data = [{"project": "test"}]
with mock.patch(
"builtins.open", mock.mock_open(read_data=json.dumps(mock_api_data))
):
proc = test_utils.new_coldfront_fetch_processor(
coldfront_data_filepath="fake/path.json"
)
result = proc._get_coldfront_api_data()
assert result == mock_api_data

@mock.patch(
"process_report.processors.coldfront_fetch_processor.ColdfrontFetchProcessor._fetch_coldfront_allocation_api",
)
def test_get_allocation_data_missing_key(self, mock_get_allocation_data):

@QuanMPhm QuanMPhm Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this test, it does not seem like you need any mocking at all. The test itself can be shortened.

    def test_get_allocation_data_missing_key(self):
        """Malformed allocation entries with missing keys are skipped."""
        test_allocation_data = [
            {
                "resource": {"name": "stack"},
                "project": {"pi": "PI1"},
                "attributes": {},
            },  # missing Allocated Project ID
        ]
        proc = test_utils.new_coldfront_fetch_processor()
        result = proc._get_allocation_data(test_allocation_data)
        assert result == {}

"""Malformed allocation entries with missing keys are skipped."""
mock_get_allocation_data.return_value = [
{
"resource": {"name": "stack"},
"project": {"pi": "PI1"},
"attributes": {},
}, # missing Allocated Project ID
]
test_invoice = self._get_test_invoice(["P1"], cluster_name=["stack"])
proc = test_utils.new_coldfront_fetch_processor(data=test_invoice)
result = proc._get_allocation_data(mock_get_allocation_data.return_value)
assert result == {} # malformed entry was skipped
Loading