Skip to content

APP-453 - update docker-compose.yaml and local dev document#738

Merged
adaball merged 3 commits intomainfrom
ab/app-453/update-local-dev
Apr 7, 2026
Merged

APP-453 - update docker-compose.yaml and local dev document#738
adaball merged 3 commits intomainfrom
ab/app-453/update-local-dev

Conversation

@adaball
Copy link
Copy Markdown
Contributor

@adaball adaball commented Apr 7, 2026

Description

This PR updates docker-compose.yaml by removing the 6 services that were consolidated from it while keeping the reporting-pipeline-service entry.

The local dev documentation has also been touched up a bit.

Related Issue

Jira Ticket

Additional Notes

  • The README update for the reporting-pipeline-service was taken care of in a previous PR

Checklist

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • [ ] I have added or updated test cases to cover my changes, if applicable.

@adaball adaball requested review from a team, ericbuckley, mpeels and timoballard April 7, 2026 14:38
@adaball adaball requested a review from a team as a code owner April 7, 2026 14:38
@adaball adaball self-assigned this Apr 7, 2026
@ericbuckley
Copy link
Copy Markdown
Contributor

I'm not sure why, but it looks like the application tests didn't run for some reason?

@adaball
Copy link
Copy Markdown
Contributor Author

adaball commented Apr 7, 2026

I'm not sure why, but it looks like the application tests didn't run for some reason?

@ericbuckley

I think it's because no files from the watched directories were updated (unless I'm misunderstanding how GH Workflows work). For instance the Application Tests have the following paths:

name: Application Tests
on:
  pull_request:
    paths:
      - "investigation-service/**"
      - "ldfdata-service/**"
      - "person-service/**"
      - "reporting-pipeline-service/**"
      - "post-processing-service/**"
      - "observation-service/**"
      - "organization-service/**"
      - "build.gradle"
      - "settings.gradle"
      - "gradle/**"

@ericbuckley
Copy link
Copy Markdown
Contributor

I'm not sure why, but it looks like the application tests didn't run for some reason?

@ericbuckley

I think it's because no files from the watched directories were updated (unless I'm misunderstanding how GH Workflows work). For instance the Application Tests have the following paths:

name: Application Tests
on:
  pull_request:
    paths:
      - "investigation-service/**"
      - "ldfdata-service/**"
      - "person-service/**"
      - "reporting-pipeline-service/**"
      - "post-processing-service/**"
      - "observation-service/**"
      - "organization-service/**"
      - "build.gradle"
      - "settings.gradle"
      - "gradle/**"

Good catch. Could you update that to include the docker-compose.yaml. Our tests now depend on the compose specification, so anytime that changes, the tests should get executed.

Copy link
Copy Markdown
Contributor

@mpeels mpeels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

@adaball adaball merged commit d2c114c into main Apr 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants