Skip to content

feat(azure): Layered Terraform samples#282

Open
mww59 wants to merge 12 commits into
mainfrom
mw/azure-layered-terraform-samples
Open

feat(azure): Layered Terraform samples#282
mww59 wants to merge 12 commits into
mainfrom
mw/azure-layered-terraform-samples

Conversation

@mww59
Copy link
Copy Markdown
Collaborator

@mww59 mww59 commented Apr 30, 2026

First pass at layered Terraform samples for Azure. Modules have been tested with successful applies in a local environment.

Previous samples have been moved to archive.

Comment thread terraform/azure/samples/0_landing_zone/acr.tf Outdated
Comment thread terraform/azure/samples/0-landing-zone/vnet.tf
Comment thread terraform/azure/samples/1-nbs6/agw-private.tf
Comment thread terraform/azure/samples/2-nbs7/agw-public.tf
Comment thread terraform/azure/samples/3_applications/argocd.tf Outdated
Comment thread terraform/azure/samples/3-applications/terraform.tf
@mww59 mww59 force-pushed the mw/azure-layered-terraform-samples branch from fde31e5 to 57226c0 Compare May 20, 2026 15:19
@sonarqubecloud
Copy link
Copy Markdown

1 similar comment
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

Comment thread terraform/azure/samples/0-landing-zone/public-dns-zone.tf Outdated
Comment thread terraform/azure/samples/0-landing-zone/resource-group.tf Outdated
Comment thread terraform/azure/samples/0-landing-zone/public-dns-zone.tf
Comment thread terraform/azure/samples/1-nbs6/agw-private.tf
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster names should be used as overwrites to the resource prefix for all the resources. We can use locals for the login

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New issue added to audit and address this across all Azure resources

Comment thread terraform/azure/modules/development/resource-group/providers.tf
Copy link
Copy Markdown
Contributor

@jolson490 jolson490 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mww59 , there's one comment of Serban's that is not yet marked as resolved, and I added a comment. Otherwise this PR LGTM, so once those two comments are resolved then I'll be happy to approve this PR.

@mww59 mww59 force-pushed the mw/azure-layered-terraform-samples branch from 92f6033 to 5c7a73a Compare June 4, 2026 16:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

@mww59 mww59 requested a review from szamfir-skylight June 5, 2026 17:09
@jolson490 jolson490 self-requested a review June 5, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants