Skip to content

[APP-358] Testing For nbs_custom#3294

Merged
adaball merged 5 commits into
mainfrom
ab/app-358/nbs-custom-testing
Jun 5, 2026
Merged

[APP-358] Testing For nbs_custom#3294
adaball merged 5 commits into
mainfrom
ab/app-358/nbs-custom-testing

Conversation

@adaball
Copy link
Copy Markdown
Contributor

@adaball adaball commented Jun 5, 2026

Description

This PR is to revise the testing for the nbs_custom Python library and compare the outputs between it and its SAS equivalent.

The integration test for nbs_custom has been updated to match other Python library reports with tablefaker data, snapshot checking, and data shape testing.

For testing SAS vs. Python output I used the preexisting nbs_custom report Line List of STD Investigation with synthetic data via tablefaker.

$ head -n2 nbscustom_*csv
==> nbscustom_py.csv <==
Program Jurisdiction OID,Patient Local ID,Event Date
1300400008,PSN10089161GA01,03/16/1992 00:00:00

==> nbscustom_sas.csv <==
Program Jurisdiction OID,Patient Local ID,Event Date
1300400008,PSN10089161GA01,03/16/1992 00:00:00
$ uv run ./scripts/uniq_line_csvs.py nbscustom_sas.csv nbscustom_py.csv
INFO:root:********************************
INFO:root:* stats for [nbscustom_sas.csv]
INFO:root:* unique line count: 501
INFO:root:* all lines in [nbscustom_sas.csv] are found in [nbscustom_py.csv]
INFO:root:********************************
INFO:root:* stats for [nbscustom_py.csv]
INFO:root:* unique line count: 501
INFO:root:* all lines in [nbscustom_py.csv] are found in [nbscustom_sas.csv]
INFO:root:********************************

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@adaball adaball marked this pull request as ready for review June 5, 2026 19:20
@adaball adaball requested a review from a team as a code owner June 5, 2026 19:20
@adaball adaball requested review from mcmcgrath13 and timoballard and removed request for a team June 5, 2026 19:20
Copy link
Copy Markdown
Contributor

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢

@adaball adaball merged commit 10ac00c into main Jun 5, 2026
3 checks passed
@adaball adaball deleted the ab/app-358/nbs-custom-testing branch June 5, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants