Conversation
- Added multiple new bitmap reference images for various charts and maps in the backstop_data/bitmaps_reference directory. - Introduced click and hover helper functions in backstop_data/engine_scripts/puppet to streamline interaction handling during visual regression tests. - Updated onBefore and onReady scripts to utilize the new helper functions for improved scenario execution. - Enhanced package.json with new BackstopJS commands for easier testing and report generation.
Collaborator
|
Looks really good. I did notice one failure when running a test directly after a reference run, and I think a quick note in the README or somewhere else about running it would be good (mostly, start storybook first, run reference on the good/stable branch, run test on new branch, etc -- if that's actually the case) 
|
khartco
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive set of regression tests for the CDC COVE Gallery visualizations by adding Storybook stories and automated visual regression testing infrastructure. It also integrates BackstopJS for visual regression testing and provides supporting scripts for user interaction automation. The changes are grouped into new Storybook stories for different visualization types, BackstopJS integration, and supporting helper scripts.
Storybook regression test stories:
Gallery.Charts.stories.tsx,Gallery.DataBite.stories.tsx, andGallery.Maps.stories.tsxto the Storybook_storiesdirectory, providing automated rendering and regression tests for a wide variety of chart, data bite, and map examples from the CDC COVE Gallery. Each story uses a helper function to verify that the visualization and its container render correctly. [1] [2] [3]BackstopJS visual regression testing integration:
package.json(backstop:reference,backstop:test,backstop:approve,backstop:open) to facilitate visual regression testing workflows.Automation scripts for BackstopJS:
clickAndHoverHelper.js,onBefore.js, andonReady.jsinbackstop_data/engine_scripts/puppet/to automate user interactions (hover, click, type, scroll) and to ensure that scenarios are fully loaded and ready for screenshot capture during BackstopJS runs. [1] [2] [3]These changes together provide a robust framework for automated regression testing of visualizations, ensuring that future changes do not introduce visual bugs.