Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several dashboard/editor issues by cleaning up Advanced Editor JSON output, standardizing filter control heights, and improving default behavior for Markup Variables.
Changes:
- Sanitizes Advanced Editor config data to remove
"__undefined__"sentinel strings from copied/applied JSON. - Tweaks styles for ComboBox/MultiSelect/NestedDropdown to align filter control heights.
- Adjusts Markup Variables Editor to auto-populate variable name/tag based on selected column/metadata key.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dashboard/src/components/DashboardFilters/DashboardFiltersEditor/components/FilterEditor.tsx | Avoids crash when markup-include visualizations have no contentEditor by using optional chaining. |
| packages/core/components/NestedDropdown/nesteddropdown.styles.css | Adjusts padding to help normalize nested dropdown height. |
| packages/core/components/MultiSelect/multiselect.styles.css | Updates border/font/padding and minor positioning tweaks to standardize MultiSelect appearance/height. |
| packages/core/components/ComboBox/combobox.styles.css | Adjusts input padding to help align ComboBox height with other filter controls. |
| packages/core/components/AdvancedEditor/AdvancedEditor.tsx | Adds sanitization to strip "__undefined__" sentinels and refactors config parsing into a helper. |
| packages/core/components/Footnotes/footnotes.css | Adds a footer class intended to control margin/padding for footnotes footer. |
| packages/core/components/Footnotes/Footnotes.tsx | Updates footer className handling (currently introduces a string interpolation bug). |
| packages/core/components/EditorPanel/components/MarkupVariablesEditor.tsx | Auto-sets variable name/tag from selected column/metadata (currently overwrites existing custom names). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/core/components/EditorPanel/components/MarkupVariablesEditor.tsx
Show resolved
Hide resolved
packages/core/components/EditorPanel/components/MarkupVariablesEditor.tsx
Show resolved
Hide resolved
packages/core/components/EditorPanel/components/MarkupVariablesEditor.tsx
Show resolved
Hide resolved
Mgetz10
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a couple miscellaneous bugs/issues around dashboards:
"__undefined__"strings as valuesTesting Steps
"__undefined__"anywhere.