Skip to content

Dashboard fixes#2647

Merged
jayb merged 5 commits intodevfrom
dashboard-fixes
Mar 30, 2026
Merged

Dashboard fixes#2647
jayb merged 5 commits intodevfrom
dashboard-fixes

Conversation

@jayb
Copy link
Copy Markdown
Collaborator

@jayb jayb commented Mar 16, 2026

Summary

This fixes a couple miscellaneous bugs/issues around dashboards:

  1. Fixes an issue where configs copied from the Advanced section contain "__undefined__" strings as values
  2. Standardizes height of some dropdown filter elements
  3. Sets appropriate default name for Markup Variables

Testing Steps

  1. Copy a config from the Advanced section. It should not contain "__undefined__" anywhere.
  2. Open a chart with a filter and change the filter type between combobox/dropdown/multiselect/nested dropdown. They should all be 41px tall.
  3. Add a Markup Variable to any visualization. It should automatically fill in the Variable Name field when you select a column.

@jayb jayb added the Hold label Mar 16, 2026
@jayb jayb force-pushed the dashboard-fixes branch from 3e46eab to 2eacd9d Compare March 19, 2026 16:27
@jayb jayb removed the Hold label Mar 27, 2026
@jayb jayb force-pushed the dashboard-fixes branch from 2eacd9d to 27d4656 Compare March 27, 2026 17:54
@jayb jayb marked this pull request as ready for review March 27, 2026 18:17
Copilot AI review requested due to automatic review settings March 27, 2026 18:17
@jayb jayb requested a review from Mgetz10 as a code owner March 27, 2026 18:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses several dashboard/editor issues by cleaning up Advanced Editor JSON output, standardizing filter control heights, and improving default behavior for Markup Variables.

Changes:

  • Sanitizes Advanced Editor config data to remove "__undefined__" sentinel strings from copied/applied JSON.
  • Tweaks styles for ComboBox/MultiSelect/NestedDropdown to align filter control heights.
  • Adjusts Markup Variables Editor to auto-populate variable name/tag based on selected column/metadata key.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/dashboard/src/components/DashboardFilters/DashboardFiltersEditor/components/FilterEditor.tsx Avoids crash when markup-include visualizations have no contentEditor by using optional chaining.
packages/core/components/NestedDropdown/nesteddropdown.styles.css Adjusts padding to help normalize nested dropdown height.
packages/core/components/MultiSelect/multiselect.styles.css Updates border/font/padding and minor positioning tweaks to standardize MultiSelect appearance/height.
packages/core/components/ComboBox/combobox.styles.css Adjusts input padding to help align ComboBox height with other filter controls.
packages/core/components/AdvancedEditor/AdvancedEditor.tsx Adds sanitization to strip "__undefined__" sentinels and refactors config parsing into a helper.
packages/core/components/Footnotes/footnotes.css Adds a footer class intended to control margin/padding for footnotes footer.
packages/core/components/Footnotes/Footnotes.tsx Updates footer className handling (currently introduces a string interpolation bug).
packages/core/components/EditorPanel/components/MarkupVariablesEditor.tsx Auto-sets variable name/tag from selected column/metadata (currently overwrites existing custom names).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jayb jayb merged commit abe55b9 into dev Mar 30, 2026
4 checks passed
@jayb jayb deleted the dashboard-fixes branch March 30, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants