Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dev tooling dependencies (notably Storybook + related packages) and modernizes several GitHub Actions workflows to use Node 20 + Yarn caching, while also cleaning up the topojson-updater utility’s install instructions/lockfiles.
Changes:
- Bump Storybook ecosystem packages (and related deps like
jsdom) and update Yarn resolutions for security/min versions. - Update CI workflows to use
actions/*@v4, Yarn cache, and repo scripts (yarn build,yarn test-unit, etc.). - Remove
package-lock.jsonfrompackages/map/topojson-updaterand update its README to reflect standalone Yarn install.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Lockfile updates reflecting Storybook/jsdom upgrades and new resolution constraints. |
| package.json | Bumps Storybook packages + adds/updates resolutions for minimum secure versions. |
| packages/map/topojson-updater/package-lock.json | Removes npm lockfile from the standalone updater utility. |
| packages/map/topojson-updater/README.txt | Updates install instructions to run Yarn in the updater folder (not root workspace). |
| .github/workflows/unit-test.yml | Switches to Node 20 + Yarn caching and repo scripts for build/test. |
| .github/workflows/test-storybook.yml | Updates to checkout@v4/setup-node@v4, adds permissions, uses yarn build. |
| .github/workflows/stylelint.yml | Adds permissions + Yarn cache in setup-node. |
| .github/workflows/storybook-deploy.yml | Modernizes install/build/deploy steps to use Yarn + repo scripts. |
| .github/workflows/reject_scss_files.yml | Uses full-depth checkout and git diff to detect newly-added .scss files. |
| .github/workflows/lint_staged.yml | Updates to Node 20 + Yarn install; lints PR-changed JS/TS files. |
| .github/workflows/backstop-test.yml | Updates to checkout@v4/setup-node@v4, adds permissions, uses yarn build. |
Files not reviewed (1)
- packages/map/topojson-updater/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.