Conversation
Viseghoh
requested review from
Mgetz10,
adamdoe,
jayb and
khartco
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates chart tooltip number formatting to avoid abbreviating values in tooltips (while keeping axis/tick abbreviation behavior unchanged), aligning tooltip display with the expected “full value” presentation.
Changes:
- Updated
useTooltipto passshouldAbbreviate=falsewhen formatting tooltip values viaformatNumber. - Updated BarChart “additional columns” tooltip formatting to pass
shouldAbbreviate=false.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/chart/src/hooks/useTooltip.tsx | Stops opting tooltips into abbreviated formatting when calling formatNumber for tooltip values. |
| packages/chart/src/components/BarChart/helpers/useBarChart.ts | Ensures additional tooltip column values are formatted without abbreviation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tooltip path was explicity opting into abbreviation instead of staying axis only. Fixed that by flipping from true to false.