Skip to content

fix: reset background color from overwritten app.css file #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdoe merged 1 commit into from
Apr 8, 2026
Merged

fix: reset background color from overwritten app.css file #2707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/components/Table/components/Cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ const Cell = ({ children, style, isBold = false, ariaLabel }) => {
// Only include aria-label if it has a value
const ariaProps = ariaLabel ? { 'aria-label': ariaLabel } : {}

// Keep whiteSpace on td style so it can be detected by tests and for proper rendering
const tdStyle = { ...style }
delete tdStyle.textOverflow
// Keep whiteSpace on td style so it can be detected by tests and for proper rendering
const tdStyle = { backgroundColor: 'initial', ...style }
delete tdStyle.textOverflow
Comment on lines +18 to +19
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting backgroundColor as an inline style on every <td> will override stylesheet-driven cell backgrounds, including Bootstrap’s .table-striped (used by DataTable via className: 'table table-striped …'). This likely removes zebra striping/other theming and makes background styling impossible via table-level CSS selectors. Consider making this background reset opt-in (e.g., a resetCellBackground prop passed from Table based on a specific class) or solving it via a more targeted CSS rule that doesn’t globally override all cell backgrounds.

Suggested change
const tdStyle = { backgroundColor: 'initial', ...style }
delete tdStyle.textOverflow
const { textOverflow, ...tdStyle } = style || {}

Copilot uses AI. Check for mistakes.

return (
<td {...ariaProps} role='gridcell' style={tdStyle}>
Expand Down
Loading