Skip to content

Dev portal#2717

Open
jayb wants to merge 2 commits intodevfrom
dev-portal
Open

Dev portal#2717
jayb wants to merge 2 commits intodevfrom
dev-portal

Conversation

@jayb
Copy link
Copy Markdown
Collaborator

@jayb jayb commented Apr 10, 2026

Summary

  • Adds a script for the dev portal to make it run more cleanly.
  • Deletes broken configs from the examples directories
  • Moves data files in the examples directories into __data__ directories so they are hidden from sidebar
  • Deletes the unused editor/example directory

@jayb jayb requested review from adamdoe and khartco as code owners April 10, 2026 18:13
Copilot AI review requested due to automatic review settings April 10, 2026 18:13
@jayb jayb requested review from Mgetz10 and Viseghoh as code owners April 10, 2026 18:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR refactors the dev portal workflow and cleans up example assets by hiding/moving data JSON under __data__ and removing broken/unused example configs.

Changes:

  • Added a dedicated dev-portal/run-dev-portal.mjs runner and updated root dev:* scripts (including strict port binding).
  • Updated example configs to reference data under __data__/ and updated the Vite config generator to skip __data__ folders.
  • Removed numerous outdated/broken example configs and data files from packages/dashboard and packages/chart.

Reviewed changes

Copilot reviewed 47 out of 115 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/dashboard/examples/sankey.json Updates file dataset paths to point into __data__/
packages/dashboard/examples/legend-issue.json Updates dataUrl to use __data__/ path
packages/dashboard/examples/filters/States.json Removes example data file (cleanup)
packages/dashboard/examples/filters/DistrictofColumbia.json Removes example data file (cleanup)
packages/dashboard/examples/filters/Delaware.json Removes example data file (cleanup)
packages/dashboard/examples/filters/California.json Removes example data file (cleanup)
packages/dashboard/examples/filters/Alabama.json Removes example data file (cleanup)
packages/dashboard/examples/ed-visits-county-file.json Removes unused/broken dashboard example config
packages/dashboard/examples/default-multi-dataset.json Removes unused/broken dashboard example config
packages/dashboard/examples/default-multi-dataset-shared-filter.json Removes unused/broken dashboard example config
packages/dashboard/examples/default-filter-control.json Removes unused/broken dashboard example config
packages/dashboard/examples/default-data.json Removes unused/broken example data file
packages/dashboard/examples/custom/js/respiratory.js Removes custom example JS (cleanup)
packages/dashboard/examples/custom/css/respiratory.css Removes custom example CSS (cleanup)
packages/dashboard/examples/covid-map.json Removes unused/broken dashboard example config
packages/dashboard/examples/api-geographies-data.json Removes unused/broken example data file
packages/dashboard/examples/api-dashboard-years.json Removes unused/broken example data file
packages/dashboard/examples/api-dashboard-data.json Removes unused/broken example data file
packages/core/generateViteConfig.js Skips __data__ directories when enumerating JSON examples
packages/chart/src/_stories/_mock/paired-bar.json Updates dataFileName to new __data__ location
packages/chart/src/_stories/_mock/paired-bar-abbr.json Updates dataFileName to new __data__ location
packages/chart/examples/xaxis.json Removes unused/broken chart example config
packages/chart/examples/metadata-variables.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/tests-non-numerics/planet-pie-example-config-nonnumeric.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/tests-date-exclusions/date-exclusions-data.json Removes example data file (cleanup)
packages/chart/examples/feature/tests-cutoff/cutoff-example-config.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/tests-covid/covid-example-config.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/tests-covid/covid-confidence-example-config.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/tests-case-rate/case-rate-example-config.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/paired-bar/paired-bar-example.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/forest-plot/log.json Removes example data file (cleanup)
packages/chart/examples/feature/deviation/planet-deviation-config.json Updates dataUrl to use __data__/ path
packages/chart/examples/feature/combo/combochart-categories_are_numbers .json Removes example data file (cleanup)
packages/chart/examples/feature/boxplot/boxplot-data.json Removes example data file (cleanup)
packages/chart/examples/feature/boxplot/box-plot-data.json Removes example data file (cleanup)
packages/chart/examples/feature/bar/additional-column-tooltip.json Updates dataUrl/dataFileName to use __data__/ paths
packages/chart/examples/feature/bar/Barchart_with_negative.json Removes example data file (cleanup)
packages/chart/examples/feature/data/age-adjusted-rates.json Removes example data file (cleanup)
package.json Replaces long dev portal commands with run-dev-portal.mjs and adds --strictPort
docs/TESTING_BEST_PRACTICES.md Updates example import path for configs in testing docs
dev-portal/run-dev-portal.mjs Adds managed process runner for dev portal/compare modes
_stories/Highlights.PackageComparison.stories.tsx Updates story import path to data under __data__/

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants