Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refactors the dev portal workflow and cleans up example assets by hiding/moving data JSON under __data__ and removing broken/unused example configs.
Changes:
- Added a dedicated
dev-portal/run-dev-portal.mjsrunner and updated rootdev:*scripts (including strict port binding). - Updated example configs to reference data under
__data__/and updated the Vite config generator to skip__data__folders. - Removed numerous outdated/broken example configs and data files from
packages/dashboardandpackages/chart.
Reviewed changes
Copilot reviewed 47 out of 115 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dashboard/examples/sankey.json | Updates file dataset paths to point into __data__/ |
| packages/dashboard/examples/legend-issue.json | Updates dataUrl to use __data__/ path |
| packages/dashboard/examples/filters/States.json | Removes example data file (cleanup) |
| packages/dashboard/examples/filters/DistrictofColumbia.json | Removes example data file (cleanup) |
| packages/dashboard/examples/filters/Delaware.json | Removes example data file (cleanup) |
| packages/dashboard/examples/filters/California.json | Removes example data file (cleanup) |
| packages/dashboard/examples/filters/Alabama.json | Removes example data file (cleanup) |
| packages/dashboard/examples/ed-visits-county-file.json | Removes unused/broken dashboard example config |
| packages/dashboard/examples/default-multi-dataset.json | Removes unused/broken dashboard example config |
| packages/dashboard/examples/default-multi-dataset-shared-filter.json | Removes unused/broken dashboard example config |
| packages/dashboard/examples/default-filter-control.json | Removes unused/broken dashboard example config |
| packages/dashboard/examples/default-data.json | Removes unused/broken example data file |
| packages/dashboard/examples/custom/js/respiratory.js | Removes custom example JS (cleanup) |
| packages/dashboard/examples/custom/css/respiratory.css | Removes custom example CSS (cleanup) |
| packages/dashboard/examples/covid-map.json | Removes unused/broken dashboard example config |
| packages/dashboard/examples/api-geographies-data.json | Removes unused/broken example data file |
| packages/dashboard/examples/api-dashboard-years.json | Removes unused/broken example data file |
| packages/dashboard/examples/api-dashboard-data.json | Removes unused/broken example data file |
| packages/core/generateViteConfig.js | Skips __data__ directories when enumerating JSON examples |
| packages/chart/src/_stories/_mock/paired-bar.json | Updates dataFileName to new __data__ location |
| packages/chart/src/_stories/_mock/paired-bar-abbr.json | Updates dataFileName to new __data__ location |
| packages/chart/examples/xaxis.json | Removes unused/broken chart example config |
| packages/chart/examples/metadata-variables.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/tests-non-numerics/planet-pie-example-config-nonnumeric.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/tests-date-exclusions/date-exclusions-data.json | Removes example data file (cleanup) |
| packages/chart/examples/feature/tests-cutoff/cutoff-example-config.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/tests-covid/covid-example-config.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/tests-covid/covid-confidence-example-config.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/tests-case-rate/case-rate-example-config.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/paired-bar/paired-bar-example.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/forest-plot/log.json | Removes example data file (cleanup) |
| packages/chart/examples/feature/deviation/planet-deviation-config.json | Updates dataUrl to use __data__/ path |
| packages/chart/examples/feature/combo/combochart-categories_are_numbers .json | Removes example data file (cleanup) |
| packages/chart/examples/feature/boxplot/boxplot-data.json | Removes example data file (cleanup) |
| packages/chart/examples/feature/boxplot/box-plot-data.json | Removes example data file (cleanup) |
| packages/chart/examples/feature/bar/additional-column-tooltip.json | Updates dataUrl/dataFileName to use __data__/ paths |
| packages/chart/examples/feature/bar/Barchart_with_negative.json | Removes example data file (cleanup) |
| packages/chart/examples/feature/data/age-adjusted-rates.json | Removes example data file (cleanup) |
| package.json | Replaces long dev portal commands with run-dev-portal.mjs and adds --strictPort |
| docs/TESTING_BEST_PRACTICES.md | Updates example import path for configs in testing docs |
| dev-portal/run-dev-portal.mjs | Adds managed process runner for dev portal/compare modes |
| _stories/Highlights.PackageComparison.stories.tsx | Updates story import path to data under __data__/ |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__data__directories so they are hidden from sidebareditor/exampledirectory