Skip to content

use payload from dispatches#142

Merged
sbidari merged 3 commits intomainfrom
116-populate-more-parameters-of-generate-visualization-data-from-client-payload-on-repository_dispatch
Apr 9, 2026
Merged

use payload from dispatches#142
sbidari merged 3 commits intomainfrom
116-populate-more-parameters-of-generate-visualization-data-from-client-payload-on-repository_dispatch

Conversation

@sbidari
Copy link
Copy Markdown
Collaborator

@sbidari sbidari commented Apr 3, 2026

No description provided.

@O957
Copy link
Copy Markdown
Contributor

O957 commented Apr 6, 2026

Originally, I had

...so that users do not manually have to enter the reference date again when https://github.com/CDCgov/covidhub-reports/blob/main/.github/workflows/generate-visualization-data.yaml is ran.

in CDCgov/covid19-forecast-hub#1163 but I am not sure whether it is best to keep manual entry an option. Right now I have ${{ inputs.reference_date || github.event.client_payload.reference_date }} instead of ${{ github.event.client_payload.reference_date }}

Copy link
Copy Markdown
Contributor

@O957 O957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for remark from @sbidari on my own comment. get_hub_repo makes sense but maybe there is marginally better name?

@sbidari
Copy link
Copy Markdown
Collaborator Author

sbidari commented Apr 6, 2026

payload does not contain reference_date, it should just be ${{ inputs.reference_date }}

@sbidari sbidari merged commit 02d734f into main Apr 9, 2026
1 check passed
@sbidari sbidari deleted the 116-populate-more-parameters-of-generate-visualization-data-from-client-payload-on-repository_dispatch branch April 9, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Populate more parameters of generate-visualization-data from client-payload on repository_dispatch

3 participants