Skip to content

HGAM simulated data#117

Open
athowes wants to merge 21 commits intomainfrom
hgam-simulations
Open

HGAM simulated data#117
athowes wants to merge 21 commits intomainfrom
hgam-simulations

Conversation

@athowes
Copy link
Collaborator

@athowes athowes commented Aug 12, 2025

The scope of this PR is to develop a notebook implementing simulated data which can be passed to a HGAM model. I'm making it in this repo, but mostly to use the review document capacity of GH. We could implement the results here too under this PR once we've agreed the data and fits look good.

I have written a plan for the work itself in the notebook.

My meta plan is:

  1. Finish notebook (with review and agreement on results being nice)
  2. Implement functions into RtGam
  3. Implement tests into gamtools

Current rendered version: 2025-09-01_hgam.html.

Remaining

  • The ST effects should be smooth over time and less spatially correlated
  • The simulate_sir() function appears to be generating cases like 10^6. Must be a bug somewhere?
  • When these are working, then need to get the forecast recovery to be good
  • And the Rt recovery to be good

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@kgostic kgostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some high level comments! Would like ZS to look too before approving, and possibly BB!

@athowes athowes requested a review from zsusswein August 19, 2025 12:49
@athowes
Copy link
Collaborator Author

athowes commented Aug 26, 2025

Error in simulate_sir() where the value of S can be negative (allowing the value of I to be really high):

image

@athowes athowes requested review from bbolker and kgostic September 1, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants