Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
kgostic
reviewed
Aug 14, 2025
Collaborator
kgostic
left a comment
There was a problem hiding this comment.
Left some high level comments! Would like ZS to look too before approving, and possibly BB!
Collaborator
Author
b509512 to
9afa01d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The scope of this PR is to develop a notebook implementing simulated data which can be passed to a HGAM model. I'm making it in this repo, but mostly to use the review document capacity of GH. We could implement the results here too under this PR once we've agreed the data and fits look good.
I have written a plan for the work itself in the notebook.
My meta plan is:
RtGamgamtoolsCurrent rendered version: 2025-09-01_hgam.html.
Remaining
simulate_sir()function appears to be generating cases like 10^6. Must be a bug somewhere?