feat(ecs): update ECS module source to use feature branch#88
Merged
Conversation
- Fix module source references to reflect git branch usage - Clarify helper script purposes (setup.sh vs deploy.sh) - Add "Before You Begin" prerequisites checklist - Add Quick Start section with 10-minute deployment guide - Add Troubleshooting section with common issues and solutions - Fix broken link in Terraform Commands section - Improve formatting with tables and code blocks
alismx
force-pushed
the
alis/web_acl_log
branch
from
5fe11e4 to
8238391
Compare
- add new sections (Before You Begin, Quick Start, Common Issues) - update architecture diagram date and file reference - remove outdated module version constraint in ECS README - add `wafv2:PutLoggingConfiguration` permission to OIDC role - minor formatting fix in OIDC main.tf
…tent to docs - Reorganize main README.md to be more concise with simplified section numbering - Remove verbose "Getting Started" details, helper scripts, secrets management, and development workflow from README.md - Create new `docs/README.md` containing all comprehensive implementation guidance - Move architecture diagram to `docs/` directory - Update section references in README.md to point to docs
alismx
force-pushed
the
alis/web_acl_log
branch
from
28c9201 to
d39fbcb
Compare
- Created docs/modules/oidc/README.md - Created docs/modules/tfstate/README.md - Updated bean dibbs-aws-2tsr to completed status This fixes the missing documentation for OIDC and TFState modules that are referenced in docs/README.md.
fix(terraform): switch ECS module to official AWS registry source 1.0.0
alismx
force-pushed
the
alis/web_acl_log
branch
from
537ac29 to
56f8566
Compare
alismx
force-pushed
the
alis/web_acl_log
branch
from
08f2b79 to
4c5405e
Compare
alismx
force-pushed
the
alis/web_acl_log
branch
from
07e2725 to
10b355c
Compare
- Pin dibbs-ecr-viewer module to commit 588457a2beaa1371c1e5f01c9ece9bf83d937b00 - Pin VPC module to commit 9ffd9c66f3d7eb4b5bc2d7bc7d049f794b127693 (v5.16.0)
- Updated module README with auto-generated documentation - Added infrastructure dependency graph (graph.png)
alismx
force-pushed
the
alis/web_acl_log
branch
10 times, most recently
from
b95b987 to
5871da0
Compare
alismx
force-pushed
the
alis/web_acl_log
branch
18 times, most recently
from
cb4eca6 to
ceb123d
Compare
shanice-skylight
approved these changes
Apr 1, 2026
Collaborator
shanice-skylight
left a comment
shanice-skylight
left a comment
There was a problem hiding this comment.
I had a couple questions but revision of documentation looks good, very thorough
Collaborator
There was a problem hiding this comment.
Why are we adding TN's specific architecture to repository?
Collaborator
Author
There was a problem hiding this comment.
I'll update this in a follow-up
| --- | ||
|
|
||
| ## Terraform documentation | ||
| If you have not used terraform before, and have the will to learn, please visit these resources before continuing. |
Collaborator
There was a problem hiding this comment.
I luv the comment "will to learn"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed