feat(ui): Convert Narrative <Switch/> to <Dropdown/>#1318
Open
rogeruiz wants to merge 1 commit into
Open
Conversation
Contributor
🔒 Security Scan Results
|
| Severity | Total |
|---|---|
| 🟠 High | 8 |
📦 refiner-app
✅ No vulnerabilities found
📦 refiner-lambda
✅ No vulnerabilities found
📦 refiner-ops
| Severity | Count |
|---|---|
| 🟠 High | 8 |
View detailed results: Security tab
Last updated: 2026-06-03 20:23:45 UTC
<Switch/> to <Dropdown/><Switch/> to <Dropdown/>
9 tasks
rogeruiz
added a commit
that referenced
this pull request
Jun 4, 2026
This patch migrates the narrative field from a boolean type to a three-value enum across the API and client. This prepares the API and the client for the work being done for #1195. This work is independent of #1317 and #1318 but closely related to them. The latter needs to be safely integrated with this patch to ensure the changes don't conflict with one another.
9 tasks
rogeruiz
added a commit
that referenced
this pull request
Jun 4, 2026
This patch migrates the narrative field from a boolean type to a three-value enum across the API and client. This prepares the API and the client for the work being done for #1195. This work is independent of #1317 and #1318 but closely related to them. The latter needs to be safely integrated with this patch to ensure the changes don't conflict with one another.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 PULL REQUEST
💡 Summary
This patch updates the narrative data toggle switch to a dropdown select
component with two options ("Keep original" and "Remove"). This only addresses
the first part of the narrative reconstruction dropdown feature. The change
replaces the
<NarrativeSwitch/>component with a new<NarrativeSelect/>component that uses the existing
<Select/>component. I'm also preserving theblanking pattern for excluded rows; if
include: falsethen no controls are shown.🔗 Related Issue
✅ Acceptance Criteria
Reconstruct option appears in the drop-down when available for thatsection
Reconstruction option grayed out unless "refine" is selected for codeddata
Updated table column names (coded data, narrative data)Updated coded data options copy (keep original, refine)Updated tooltip copyIf user has "reconstruct" for the narrative and tries to change codeddata to "keep original", error appears under the toggle
narrative
for coded data or refined data)
🧪 How to test
just dev upto bring up the application locallyConfirm that the narrative column now displays a dropdown instead of a toggle
switch.
just client run lint fmt check test e2eℹ️ Additional Information
Note
The work related to #1195 will be applied in four different patches/PRs
continuing with this one. Each patch will be as independent as possible and rely
only on prior patches as strictly necessary. This patch relies on the changes
introduced in #1317.