Skip to content

fix(sections): ReconstructableSection as policy#1412

Open
rogeruiz wants to merge 6 commits into
mainfrom
rogeruiz/1016/policy-for-section-reconstruction
Open

fix(sections): ReconstructableSection as policy#1412
rogeruiz wants to merge 6 commits into
mainfrom
rogeruiz/1016/policy-for-section-reconstruction

Conversation

@rogeruiz

Copy link
Copy Markdown
Collaborator

🔀 PULL REQUEST

💡 Summary

This is a bug I introduced in my misunderstanding of the work related to #1016
and implementing #1195. This fixes the issue that @kplaneaux caught in manual
testing of that work in the AIMS development site. Since it makes the most sense
to have these in the Policy service, that's where they are and can be used on
the client-side to ensure only the sections appearing in this new class are
available to the server and the client.

🔗 Related Issue

✅ Acceptance Criteria

  • Only specific sections should have a Reconstruct option. For now, it's the
    Results section only.

🧪 How to test

  1. Run just server test -vvv refiner/tests/unit/test_service_policy.py
  2. Run the UI just dev up and verify that under Sections that Results is
    the only one that allows for the Reconstuct option in the dropdown under
    the Narrative data column.

This is a bug I introduced in my misunderstanding of the work related to #1016
and implementing #1195. This fixes the issue that @kplaneaux caught in manual
testing of that work in the AIMS development site. Since it makes the most sense
to have these in the Policy service, that's where they are and can be used on
the client-side to ensure only the sections appearing in this new class are
available to the server and the client.

Co-Authored-By: Robert Mitchell <utu9@cdc.gov>
@rogeruiz rogeruiz requested a review from lina-roth as a code owner June 22, 2026 22:30
@rogeruiz rogeruiz added bug Something isn't working dibbs-ecr-refiner labels Jun 22, 2026
@rogeruiz rogeruiz requested a review from jakewheeler as a code owner June 22, 2026 22:30
@rogeruiz rogeruiz added ux/ui Primarily client-side work with minimal server work needed. server-side Primarily server-side work with minimal client work needed. labels Jun 22, 2026
@rogeruiz rogeruiz self-assigned this Jun 22, 2026
rogeruiz added 2 commits June 22, 2026 17:30
Merge remote-tracking branch 'origin/main' into rogeruiz/1016/policy-for-section-reconstruction
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🔒 Security Scan Results

⚠️ Found 15 vulnerabilities

Severity Total
🟠 High 12
🟡 Medium 3

📦 refiner-app

No vulnerabilities found

📦 refiner-lambda

Severity Count
🟠 High 4

📦 refiner-ops

Severity Count
🟠 High 8
🟡 Medium 3

View detailed results: Security tab
Last updated: 2026-06-22 23:37:06 UTC

@kplaneaux

Copy link
Copy Markdown
Collaborator

Are we able to see programmatically which sections have a reconstruct option in order to add it to their drop-downs rather than needing to add the option manually as we go?

@rogeruiz rogeruiz changed the title fix(sections): ReconstructableSection as policy; fix(sections): ReconstructableSection as policy Jun 22, 2026
@rogeruiz

Copy link
Copy Markdown
Collaborator Author

Are we able to see programmatically which sections have a reconstruct option in order to add it to their drop-downs rather than needing to add the option manually as we go?

Good question @kplaneaux I checked with the team and I believe this is the best alternative we have. This data isn't available to us from the TES. So we are using our Policy service to lock down which Sections are considered Reconstructable. So technically yes, this is all done programmatically, but we will still need to activate Sections as Reconstructable manually by adding/uncommenting them from the introduced class in .../policy.py.

@rogeruiz rogeruiz enabled auto-merge June 22, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dibbs-ecr-refiner server-side Primarily server-side work with minimal client work needed. ux/ui Primarily client-side work with minimal server work needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants