-
Notifications
You must be signed in to change notification settings - Fork 2
major: set default schema for kysely migration tables #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 86.03% 90.53% +4.49%
==========================================
Files 253 174 -79
Lines 11248 6505 -4743
Branches 1189 1198 +9
==========================================
- Hits 9677 5889 -3788
+ Misses 1564 609 -955
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Waiting for this PR to be merged and released before this can be completed. |
PULL REQUEST
Summary
Sets default schema for Kysley migration tables to match the schema of the other tables we are creating instead of writing them to the database default. Removes schema creation from init migration.
Related Issue
Fixes #1102
Acceptance Criteria
ecr_viewerschema.ecr_viewerschema during the infrastructure setup stageecr_viewerschema does NOT existmigrationTableNameandmigrationLockTableNamefall under theecr_viewerschemaAdditional Information
Anything else the review team should know?
Checklist