Conversation
Add JSON task definitions and README for deploying eCR Viewer services to Amazon ECS, including ecr-viewer, fhir-converter, fhir-converter-proxy, ingestion, message-parser, orchestration, and trigger-code-reference.
alismx
requested review from
angelathe and
vochaparro2
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
- Coverage 86.40% 85.29% -1.11%
==========================================
Files 259 24 -235
Lines 11584 1190 -10394
Branches 1343 0 -1343
==========================================
- Hits 10009 1015 -8994
+ Misses 1568 175 -1393
+ Partials 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolve remaining merge conflicts in README.md, ecr-viewer.json, orchestration.json, and trigger-code-reference.json.
alismx
changed the title
Rewrite deployment/ecs/README.md from reference-style to workflow-first structure modeled on deployment/vm/README.md. Adds 5 new sections (Quick Start, Architecture, Deployment Steps, File Layout, Troubleshooting), expands Prerequisites to 8-item checkbox checklist, absorbs Registration into Deployment Steps, renames "Service-Specific Notes" to "Service-Specific Configuration", and wires cross-references between sections. Total: 200 insertions, 48 deletions across 15+ sections.
# Conflicts: # deployment/ecs/README.md
alismx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.