feat: process-ecr api endpoint
#712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
+ Coverage 87.55% 91.09% +3.53%
==========================================
Files 274 140 -134
Lines 14215 5311 -8904
Branches 903 915 +12
==========================================
- Hits 12446 4838 -7608
+ Misses 1752 456 -1296
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcmcgrath13
changed the title
…gov/dibbs-ecr-viewer into mcm/feat-api-process-message
mcmcgrath13
changed the title
process-message api endpoint
mcmcgrath13
requested review from
JNygaard-Skylight and
akasper
and removed request for
a team
mcmcgrath13
changed the title
process-message api endpointprocess-ecr api endpoint
mcmcgrath13
commented
May 15, 2025
…o mcm/feat-api-process-message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Add the
process-ecrendpoint to the viewer. Similar to theprocess-zipendpoint for the viewer, hardcode the fields that are known and only ask for the data. The message endpoint supports both form and json data (because Rhapsody 6 can't do forms in a sane way 😭 ).Rewrite
process-ziprequests intoprocess-ecrvia middleware and have the logic for getting the data and putting it in the right place over onprocess-ecr. Left a readme to that effect in the api folder so that lost souls might find their way.Related Issue
Fixes #698
Acceptance Criteria
New /process-message endpoint exists on eCR Viewer
New endpoint should:
Accept eICR and RR in the request body, like orchestration does today
Determine which orchestration configuration is applicable based on eCR Viewer environment variables (AWS, Azure, integrated, non-integrated, etc)
Send the eCR and RR to the orchestration service for processing
Accept the orchestration response
Save eCR data from orchestration (to S3, SQL Server, etc)