-
Notifications
You must be signed in to change notification settings - Fork 1
feat: program details pane #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 85.99% 90.94% +4.95%
==========================================
Files 255 145 -110
Lines 12137 5424 -6713
Branches 927 930 +3
==========================================
- Hits 10437 4933 -5504
+ Misses 1694 474 -1220
- Partials 6 17 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dataSortable: false, | ||
sortDirection: "", | ||
formatter: (conditions: ConditionReference[]) => | ||
`${conditions.length} condition${conditions.length === 1 ? "" : "s"}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are other places where we need a pluralizer. Should this be in a utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do have one for age, but it isn't exported. It's just such a weeeeeee util that I've flip flopped several times on whether its worth it - thoughts?
PULL REQUEST
Summary
Add a program details side panel when a user clicks on a program area's name.
Note, this design doesn't quite match figma, but instead is consistent with the user one and we can iterate later
Related Issue
Fixes #727
Acceptance Criteria
Side panel with the following:
Additional Information