Skip to content

feat: program details pane #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: program details pane #728

wants to merge 7 commits into from

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented May 16, 2025

PULL REQUEST

Summary

Add a program details side panel when a user clicks on a program area's name.

Note, this design doesn't quite match figma, but instead is consistent with the user one and we can iterate later

Related Issue

Fixes #727

Acceptance Criteria

Side panel with the following:

  • Name
  • Created date information [DD/MM/YYYY 0:00 (User Time Zone), ie. 3/4/25 8:30 AM PST)
  • Number of conditions included in the program area
  • List of conditions in the program area
  • Ability to close the side panel using the (X)

Additional Information

image

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.94%. Comparing base (68cc400) to head (6607505).

Files with missing lines Patch % Lines
.../ecr-viewer/src/app/admin/program/ProgramTable.tsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   85.99%   90.94%   +4.95%     
==========================================
  Files         255      145     -110     
  Lines       12137     5424    -6713     
  Branches      927      930       +3     
==========================================
- Hits        10437     4933    -5504     
+ Misses       1694      474    -1220     
- Partials        6       17      +11     
Flag Coverage Δ
ecr-viewer 92.82% <90.90%> (-0.01%) ⬇️
fhir-converter ?
ingestion ?
message-refiner ?
orchestration 85.45% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcmcgrath13 mcmcgrath13 changed the title feat: wip - program details pane feat: program details pane May 19, 2025
@mcmcgrath13 mcmcgrath13 marked this pull request as ready for review May 19, 2025 15:13
@mcmcgrath13 mcmcgrath13 requested a review from a team as a code owner May 19, 2025 15:13
@mcmcgrath13 mcmcgrath13 requested review from akasper and JNygaard-Skylight and removed request for a team May 19, 2025 15:13
dataSortable: false,
sortDirection: "",
formatter: (conditions: ConditionReference[]) =>
`${conditions.length} condition${conditions.length === 1 ? "" : "s"}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are other places where we need a pluralizer. Should this be in a utils?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do have one for age, but it isn't exported. It's just such a weeeeeee util that I've flip flopped several times on whether its worth it - thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program Management UI: View Program Area
3 participants