Skip to content

Augmentation Updates for V3 Spec Modifications#380

Merged
BradySkylight merged 21 commits intomainfrom
brady/363/augmentation-update
Mar 26, 2026
Merged

Augmentation Updates for V3 Spec Modifications#380
BradySkylight merged 21 commits intomainfrom
brady/363/augmentation-update

Conversation

@BradySkylight
Copy link
Copy Markdown
Collaborator

@BradySkylight BradySkylight commented Mar 24, 2026

Description

Updated the Augmenter to satisfy the changes for V3 of the Augmentation spec given to us by APHL.

  • Remove FunctionCode from Header Author section
  • Add additional information and comment for the softwareName element
  • Correct typo in the system oid
  • Added additional values to the applicationcode enum and methods to get those values back
  • Updated and added tests

See examples below of the changes requested:

image

Example of Author Header (provided by APHL):
image

Example of entry level with changes requested for Author (Provided by APHL):
image

Related Issues

Closes #363

Additional Notes

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (9f67c66) to head (2d55fe1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   93.49%   93.53%   +0.03%     
==========================================
  Files          40       40              
  Lines        2107     2120      +13     
==========================================
+ Hits         1970     1983      +13     
  Misses        137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The OID fix, functionCode removal from header, and softwareName enrichment all look correct. A few suggestions below:

Copy link
Copy Markdown
Collaborator

@JNygaard-Skylight JNygaard-Skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@nickclyde nickclyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Brady!

@BradySkylight BradySkylight merged commit d9ea87e into main Mar 26, 2026
5 checks passed
@BradySkylight BradySkylight deleted the brady/363/augmentation-update branch March 26, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Augmentation to fit the latest changes from APHL

6 participants