Skip to content

Skip Slack review notification for Dependabot PRs#422

Merged
nickclyde merged 1 commit intomainfrom
nickclyde/disable-slack-dependabot
Apr 2, 2026
Merged

Skip Slack review notification for Dependabot PRs#422
nickclyde merged 1 commit intomainfrom
nickclyde/disable-slack-dependabot

Conversation

@nickclyde
Copy link
Copy Markdown
Member

@nickclyde nickclyde commented Apr 2, 2026

Summary

  • Adds github.actor != 'dependabot[bot]' condition to the Slack review notifier workflow so it doesn't fire for automated Dependabot PRs
  • Dependabot-triggered workflows don't have access to repo secrets (SLACK_WEBHOOK_URL), causing the check to fail on every Dependabot PR
  • It's not worth risking leaking the webhook URL in case dependabot is compromised
  • The daily open-PRs cron (slack_notifier_open_pulls.yml) already surfaces these to the team

Resolves #402

Copy link
Copy Markdown
Collaborator

@BradySkylight BradySkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.27%. Comparing base (6c63a05) to head (441c44b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          42       42           
  Lines        2161     2161           
=======================================
  Hits         2059     2059           
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickclyde nickclyde merged commit 94ca96e into main Apr 2, 2026
6 checks passed
@nickclyde nickclyde deleted the nickclyde/disable-slack-dependabot branch April 2, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Dependabot posts not getting to slack

4 participants