Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 95.27% 95.74% +0.46%
==========================================
Files 42 42
Lines 2161 2161
==========================================
+ Hits 2059 2069 +10
+ Misses 102 92 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nickclyde
left a comment
There was a problem hiding this comment.
Good stuff! Just one suggestion below
| """Tests old document id gets assigningAuthorityName when missing.""" | ||
| augmenter = EICRAugmenter(BASIC_ECR, []) | ||
|
|
||
| parent_doc_id = augmenter._get_old_document_id() | ||
|
|
||
| assert parent_doc_id.get("assigningAuthorityName") == "original-document" | ||
|
|
There was a problem hiding this comment.
The test name says "when missing" but BASIC_ECR already has assigningAuthorityName="original-document" on the <id> element, so this is actually testing the attribute-already-present path. The test at line 146 (test_get_old_document_id_sets_assigning_authority_name_when_missing_attribute) is the one that truly tests the missing case.
Suggested rename: test_get_old_document_id_preserves_assigning_authority_name_when_present.
Description
Small touch ups still needed for utils, augmentation. Should get us to 100% coverage in everything but data_curation, which I have not really worked on before, so a little cautious about taking that on: https://app.codecov.io/gh/CDCgov/dibbs-text-to-code/tree/rob%2Fcoverage-touchups/packages
Related Issues
Closes #[Link any related issues or tasks from your project management system.]
Additional Notes
[Add any additional context or notes that reviewers should know about.]
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: