Skip to content

Patient data download for data retention#8981

Merged
DavidMcClatchey merged 108 commits into
mainfrom
david/patient-data-download
Jul 29, 2025
Merged

Patient data download for data retention#8981
DavidMcClatchey merged 108 commits into
mainfrom
david/patient-data-download

Conversation

@DavidMcClatchey
Copy link
Copy Markdown
Collaborator

@DavidMcClatchey DavidMcClatchey commented Jul 7, 2025 •
edited
Loading

BACKEND PULL REQUEST

Related Issue

Changes Proposed

  • Creates a dropdown on the manage patients page where users can download either facility patient data or organization patient data depending on their permissions
  • A modal pops up to confirm when a user clicks on one of the download options
  • Removes the test result download button from the "Manage Organization" tab

Testing

  • Test on Patients tab in dev2 in "Mount Olympus Healthcare" org, using "CSV uploadss" facility. This facility has 185k patients and the org has 187k patients, which is just above the maximum size of the biggest org in prod.

arinkulshi-skylight and others added 30 commits May 26, 2025 12:29
@arinkulshi-skylight
initial test result download logic added
5bd0768
@arinkulshi-skylight
linting
4542b61
@arinkulshi-skylight
Merge branch 'main' into arin/test-results-data-download
c94b22c
@arinkulshi-skylight
removed validation which is not needed on download
77c0fdc
@arinkulshi-skylight
renamed file improved logic
55e106f
@arinkulshi-skylight
removed client side validation
be65ce4
@arinkulshi-skylight
comments
087014b
@arinkulshi-skylight
edited csv download to be more robust and updated frontend tests
1cd66d4
@arinkulshi-skylight
added better messaging around the download time.
1f48776
@arinkulshi-skylight
linting
5702689
@arinkulshi-skylight
linting
10c782c
@arinkulshi-skylight
remove unneeded files
855ab49
@arinkulshi-skylight
remove unneeded files
e9d1b80
@arinkulshi-skylight
reverted original streaming response
4a8b314
@arinkulshi-skylight
edited the batch size
53d9524
@arinkulshi-skylight
added logic to clean up button animation
4c73acd
@arinkulshi-skylight
Merge branch 'main' into arin/test-results-data-download
458c535
@arinkulshi-skylight
added zip logic and improved query time with entity graph.
0082e54
@arinkulshi-skylight
updated tests
38333ce
@arinkulshi-skylight
Merge branch 'main' into arin/test-results-data-download
708a7be
@DavidMcClatchey
wip
202f601
@arinkulshi-skylight
added organization logic as well as made endpoint more generic. to fi…
0cb0e00 
…t both org and facility exports.
@arinkulshi-skylight
linting
2ffc788
@DavidMcClatchey
Merge branch 'main' into david/patient-data-download
8d14704
@DavidMcClatchey
simplifying csv fields
ddd6464
@DavidMcClatchey
Merge branch 'arin/test-results-data-download' into david/patient-dat…
4fd5a7c 
…a-download
@arinkulshi-skylight
disabled org level downloads on facility page.
e884ecb
@arinkulshi-skylight
updated frontend tests/snapshots
6d92c22
@arinkulshi-skylight
updated tests to address entityGraph
59df5f5
@arinkulshi-skylight
added logic for org export on facility page.
4bc2bac
arinkulshi-skylight
arinkulshi-skylight reviewed Jul 24, 2025
View reviewed changes
Comment thread backend/src/main/java/gov/cdc/usds/simplereport/service/CsvExportService.java Outdated
@arinkulshi-skylight arinkulshi-skylight self-requested a review July 24, 2025 19:24
arinkulshi-skylight
arinkulshi-skylight previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@arinkulshi-skylight arinkulshi-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the download in dev2.I love the download button on the manage patients page it looks much cleaner this way. Amazing work!

@arinkulshi-skylight arinkulshi-skylight self-requested a review July 24, 2025 23:47
kevinfiol
kevinfiol reviewed Jul 25, 2025
View reviewed changes
Comment thread frontend/src/app/utils/testResultCSV.ts Outdated
kevinfiol
kevinfiol reviewed Jul 25, 2025
View reviewed changes
Comment thread frontend/src/app/patients/ManagePatients.tsx Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 28, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
64.9% Coverage on New Code (required ≥ 80%)
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@arinkulshi-skylight arinkulshi-skylight self-requested a review July 28, 2025 22:49
@DavidMcClatchey DavidMcClatchey added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 5152847 Jul 29, 2025
44 of 45 checks passed
@DavidMcClatchey DavidMcClatchey deleted the david/patient-data-download branch July 29, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinfiol kevinfiol kevinfiol approved these changes

@schreiaj schreiaj Awaiting requested review from schreiaj schreiaj is a code owner automatically assigned from CDCgov/simplereport-engineeringreviews

@mehansen mehansen Awaiting requested review from mehansen mehansen is a code owner automatically assigned from CDCgov/simplereport-engineeringreviews

@DanielSass DanielSass Awaiting requested review from DanielSass DanielSass is a code owner automatically assigned from CDCgov/simplereport-engineeringreviews

@mpbrown mpbrown Awaiting requested review from mpbrown mpbrown is a code owner automatically assigned from CDCgov/simplereport-engineeringreviews

+1 more reviewer

@arinkulshi-skylight arinkulshi-skylight arinkulshi-skylight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DavidMcClatchey @kevinfiol @github-advanced-security @arinkulshi-skylight