Send single entry results to HL7 queue#9134
Conversation
mpbrown
changed the title
mpbrown
force-pushed
the
mike/8834-hl7-single-entry-queue
branch
from
c8b880d to
f78491f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mpbrown
requested review from
DanielSass,
DavidMcClatchey,
arinkulshi-skylight,
kevinfiol,
mehansen and
schreiaj
and removed request for
a team
|
|
Tested by submitting a test event on dev5, and verified:
|
| .build(); | ||
| } | ||
|
|
||
| @Profile("!" + PROD) |
There was a problem hiding this comment.
Does this just mean "NOT PROD"?
There was a problem hiding this comment.
Yeah and this same Spring profile pattern is also used for the covid pipeline (csvQueue) and universal pipeline (fhirQueue) to determine which implementation should be used at runtime
kevinfiol
left a comment
kevinfiol
left a comment
There was a problem hiding this comment.
Works well and I see no obvious errors. I noted in a comment above about some more error handling we may want to do in the future.
DavidMcClatchey
left a comment
DavidMcClatchey
left a comment
There was a problem hiding this comment.
A couple of non-blocking suggestions but looks good code-wise and was able to land a message in the S3 bucket from dev5!
| } catch (IOException e) { | ||
| throw new TestEventSerializationFailureException( | ||
| testEvent.getInternalId(), e.getCause().getMessage()); | ||
| testEvent.getInternalId(), e.getCause().getMessage(), "Covid"); |
There was a problem hiding this comment.
Slightly out of scope, but, as long as we're touching this file, do we need to be adding this with the covid csv pipeline going/gone away? Is it possible to delete this whole file along with the csvQueueReportingService bean definitions in AzureTestEventReportingQueueConfiguration? My only hesitation for not doing that would be if any alerts are affected.
There was a problem hiding this comment.
Primarily left the Covid pipeline stuff so that any deletion could be handled in #8979 since otherwise it would also involve modifying/removing tests and at that point feels quite out of scope with the rest of this ticket
mpbrown
dismissed stale reviews from DavidMcClatchey and kevinfiol
via
c814113
|
Thanks for the reviews! Updated this with some of those minor fixes |
mpbrown
dismissed stale reviews from kevinfiol and DavidMcClatchey
via
4bd3eee
|
Reverted the commits that changed the |
mpbrown
force-pushed
the
mike/8834-hl7-single-entry-queue
branch
from
4bd3eee to
9befbd2
Compare
|
4 participants
BACKEND PULL REQUEST
Related Issue
Changes Proposed
aimsReportingEnabledfeature flagAdditional Information
aimsReportingEnabledis true, the app will send single entry results to the HL7QueueReportingService. The value ofsimple-report.azure-reporting-queue.hl7-queue-enabledwill determine if it is sent to the Azure queue or if the no-op service is used instead.aimsReportingEnabledandhl7-queue-enabledshould both be falseaimsReportingEnabledandhl7-queue-enabledshould both be true. This means all single entry results submitted in Azure dev environments will be sent to AIMS.aimsReportingEnabledshould be true, buthl7-queue-enabledshould be false so that it defaults to the no-op configuration. If testing the Azure queue is necessary for local development, you can always just overridehl7-queue-enabledlocally.aimsReportingEnabled. That flag will only determine whether the test event is also sent to AIMS.Testing
hl7v2-data-publishingin dev5 (recommend Azure Storage Explorer instead of the Azure portal, but either works fine)ORU^R01^ORU_R01node aims.ts listsent