Updating person and test_event metabase views#9258
Merged
Conversation
DavidMcClatchey
requested review from
DanielSass,
kevinfiol,
mpbrown and
schreiaj
and removed request for
a team
|
mpbrown
approved these changes
Nov 4, 2025
Collaborator
mpbrown
left a comment
mpbrown
left a comment
There was a problem hiding this comment.
LGTM checking the views locally, left one question about replacing views
| - createView: | ||
| viewName: person_no_phi_view | ||
| remarks: A subset of the person table with columns containing PHI removed. | ||
| replaceIfExists: true |
Collaborator
There was a problem hiding this comment.
Does this option mean we don't necessarily need to use the dropView changes above?
Collaborator
Author
There was a problem hiding this comment.
Yea I was wondering that as well - that's what we've done in the past, and I figured it shouldn't hurt anything to be doubly sure that the view gets dropped
kevinfiol
reviewed
Nov 4, 2025
schreiaj
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BACKEND PULL REQUEST
Testing