Updating assigning authority on different segments#9385
Conversation
DavidMcClatchey
requested review from
DanielSass,
kevinfiol,
mpbrown and
schreiaj
and removed request for
a team
mpbrown
left a comment
mpbrown
left a comment
There was a problem hiding this comment.
Looks good overall! Left a few questions but nothing blocking
| public static final String SIMPLE_REPORT_NAME = "SimpleReport"; | ||
|
|
||
| /** Note: this is the CDC OID for now until we get a SimpleReport OID registered */ | ||
| public static final String SIMPLE_REPORT_ORG_OID = "2.16.840.1.114222.4"; |
There was a problem hiding this comment.
[suggestion]: Now that we're no longer using this old CDC OID, could this PR remove the old comment in HL7Properties.java?
Do you think we should update the name of sendingApplicationNamespace and sendingApplicationOID to something else now that it is used beyond just MSH-3 Sending Application? 🤔
There was a problem hiding this comment.
How about simpleReportNamespace and simpleReportOID?
| identifierEntry.getCx4_AssigningAuthority().getHd1_NamespaceID().setValue(namespaceId); | ||
| } | ||
| identifierEntry | ||
| .getCx6_AssigningFacility() |
There was a problem hiding this comment.
[question]: What info has APHL shared regarding PID-3.6 Assigning Facility? Is it expected that these are the same values as assigning authority?
There was a problem hiding this comment.
I'm seeing in the story that PID-3.6.1 should be our SIMPLEREPORT.(env) namespace and PID-3.6.2 should be our OID that APHL assigned to us. For the scenario where a facility has their own external id for a patient, I assume it makes sense to use the CLIA as OID and facility name as namespace as described by Millie [here].(https://teams.microsoft.com/l/message/19:74e04fd8733445c784114a8b89fa3884@thread.v2/1768501437243?context=%7B%22contextType%22%3A%22chat%22%7D)
Do you think that's incorrect for either the internal (SimpleReport) patient id scenario or external (facility) patient id scenario?
There was a problem hiding this comment.
Oh whoops I forgot PID-3.6 was included in the story, the change just stood out as a new field we're adding. The naming feels a bit strange that the assigning authority for a patient external id would be listed as the facility CLIA, but the assigning facility listed as SR, but I suppose that's what APHL/STLTs expect 🤷
There was a problem hiding this comment.
The assigning facility for a patient external id would have the facility name for the namespace ID (PID-3.6.1) and the CLIA for the Universal ID (PID-3.6.2), but that also made me think the variable names that get passed into this method are now confusing and should be changed from assigningAuthorityNamespaceId to simply namespaceId and from assigningAuthorityUniversalId to universalId. I'll go ahead and make that change and open to another alternative if you think something different makes sense.
There was a problem hiding this comment.
Ah okay that makes sense now! I was indeed getting confused from the variable names so yeah I think that's a great change to make
|
mpbrown
left a comment
mpbrown
left a comment
There was a problem hiding this comment.
LGTM! Thanks for updating those variable names!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
4 participants
BACKEND PULL REQUEST
Related Issue
Changes Proposed
namespaceIdanduniversalId(OID that APHL gave us) where requested. In production, we have one set of values fornamespaceIdanduniversalIdand then all other (lower) environments share anothernamespaceIdanduniversalId.assigning authority values of an external patient idto use the performing facility's name as thenamespaceIdand the performing facility's CLIA as theuniversalId.Additional Information
Testing